Bug 220606 – Add a quirk to disable "return to element fullscreen from picture-in-picture" for some sites

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Peng Liu]

Add a quirk to disable "return to element fullscreen from picture-in-picture" for some sites

[Peng Liu]

Created attachment 417572 [details]
Patch

[Peng Liu]

<rdar://problem/70788878>

[Peng Liu]

Created attachment 417575 [details]
Rebase the patch

[Peng Liu]

Created attachment 417591 [details]
Fix build failures

[Peng Liu]

Created attachment 417595 [details]
Patch

[Eric Carlson]

Comment on attachment 417595 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=417595&action=review

> Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm:893
> +    if (!_blocksReturnToFullscreenFromPictureInPicture)
> +        _shouldReturnToFullscreenFromPictureInPicture = YES;

This could be simplified to `_shouldReturnToFullscreenFromPictureInPicture = !_blocksReturnToFullscreenFromPictureInPicture`

[Peng Liu]

Comment on attachment 417595 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=417595&action=review

>> Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm:893
>> +        _shouldReturnToFullscreenFromPictureInPicture = YES;
> 
> This could be simplified to `_shouldReturnToFullscreenFromPictureInPicture = !_blocksReturnToFullscreenFromPictureInPicture`

Right!

[Peng Liu]

Created attachment 417652 [details]
Revise the patch based on Eric's comment

[EWS]

Committed r271503: <https://trac.webkit.org/changeset/271503>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 417652 [details].