Bug 220596 – PCM: Output logs by default, including to Web Inspector

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[John Wilander]

Logging for PCM should be readily available in Web Inspector and not require the experimental PCM Debug Mode.

[Radar WebKit Bug Importer]

<rdar://problem/73159180>

[John Wilander]

Created attachment 417550 [details]
Patch

[John Wilander]

mac-debug-wk1 layout test failure unrelated. Looks flaky in history view. I pinged the bot watchers.

[Brent Fulgham]

Comment on attachment 417550 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=417550&action=review

r=me

> Source/WebCore/loader/PrivateClickMeasurement.cpp:65
> +        return makeUnexpected("[Private Click Measurement] Conversion was not accepted because the URL's protocol is not HTTPS or the URL contains one or more of username, password, query string, and fragment."_s);

Do we need to do any kind of feature check to decide whether to handle the attribution requests? Or does the flag only controlling emitting the report?

After thinking about it, I think that makes good sense since a developer could test (and see this output in WebInspector) without actually triggering any conversion events.

[John Wilander]

(In reply to Brent Fulgham from comment #4)
> Comment on attachment 417550 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=417550&action=review
> 
> r=me
> 
> > Source/WebCore/loader/PrivateClickMeasurement.cpp:65
> > +        return makeUnexpected("[Private Click Measurement] Conversion was not accepted because the URL's protocol is not HTTPS or the URL contains one or more of username, password, query string, and fragment."_s);
> 
> Do we need to do any kind of feature check to decide whether to handle the
> attribution requests? Or does the flag only controlling emitting the report?
> 
> After thinking about it, I think that makes good sense since a developer
> could test (and see this output in WebInspector) without actually triggering
> any conversion events.

Yes, I think that's right. Thanks for the review!

[EWS]

Committed r271473: <https://trac.webkit.org/changeset/271473>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 417550 [details].