[GStreamer][EME][Thunder] Bail out on failed response message for challenges

[Xabier Rodríguez Calvar]

[GStreamer][EME][Thunder] Bail out on failed response message for challenges

[Xabier Rodríguez Calvar]

Created attachment 417517 [details]
Patch

[Philippe Normand]

Comment on attachment 417517 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=417517&action=review

> Source/WebCore/platform/graphics/gstreamer/eme/CDMThunder.cpp:365
> +        ASSERT_NOT_REACHED();

How is this different from an ASSERT? In debug build you'll still crash here if the framework sent an empty message.

[Xabier Rodríguez Calvar]

(In reply to Philippe Normand from comment #2)
> Comment on attachment 417517 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=417517&action=review
> 
> > Source/WebCore/platform/graphics/gstreamer/eme/CDMThunder.cpp:365
> > +        ASSERT_NOT_REACHED();
> 
> How is this different from an ASSERT? In debug build you'll still crash here
> if the framework sent an empty message.

Cause there is a return and it won't crash in line 370.

[EWS]

Committed r271437: <https://trac.webkit.org/changeset/271437>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 417517 [details].

[Radar WebKit Bug Importer]

<rdar://problem/73147394>