Bug 220577 - Defer setting up app highlight menus until needed to not delay launch time.
Summary: Defer setting up app highlight menus until needed to not delay launch time.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Megan Gardner
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-01-12 21:25 PST by Megan Gardner
Modified: 2021-01-13 12:38 PST (History)
3 users (show)

See Also:

Attachments
Patch (4.25 KB, patch)
2021-01-12 21:36 PST, Megan Gardner 		no flags Details | Formatted Diff | Diff
Patch (3.81 KB, patch)
2021-01-13 08:59 PST, Megan Gardner 		no flags Details | Formatted Diff | Diff
Patch for landing (3.84 KB, patch)
2021-01-13 10:25 PST, Megan Gardner 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Megan Gardner 2021-01-12 21:25:49 PST 
Defer setting up app highlight menus until needed to not delay launch time.
Comment 1 Megan Gardner 2021-01-12 21:36:50 PST 
Created attachment 417507 [details]
Patch
Comment 2 Tim Horton 2021-01-12 22:52:34 PST 
Comment on attachment 417507 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=417507&action=review

> Source/WebKit/UIProcess/ios/WKContentView.mm:625
> +    _hasSetUpAppHighlightMenus = NO;

Do we need to do this? It doesn't seem like we would need to set them back up when the web process crashes, since they have no web process state associated with them.
Comment 3 Megan Gardner 2021-01-13 08:59:33 PST 
Created attachment 417540 [details]
Patch
Comment 4 Tim Horton 2021-01-13 09:21:17 PST 
Comment on attachment 417540 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=417540&action=review

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:-846
> -    [self setupAppHighlightMenus];

setup or setUp? Please pick one, not both.
Comment 5 Megan Gardner 2021-01-13 10:25:28 PST 
Created attachment 417546 [details]
Patch for landing
Comment 6 EWS 2021-01-13 11:05:49 PST 
Committed r271445: <https://trac.webkit.org/changeset/271445>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 417546 [details].
Comment 7 Radar WebKit Bug Importer 2021-01-13 11:06:17 PST 
<rdar://problem/73158517>
Comment 8 Megan Gardner 2021-01-13 12:38:35 PST 
rdar://72940219