Bug 220573 - PCM: Experimental debug mode needs to be read from defaults differently on iOS
Summary: PCM: Experimental debug mode needs to be read from defaults differently on iOS
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: John Wilander
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-01-12 16:54 PST by John Wilander
Modified: 2021-01-13 11:42 PST (History)
2 users (show)

See Also:

Attachments
Patch (2.17 KB, patch)
2021-01-12 16:59 PST, John Wilander 		no flags Details | Formatted Diff | Diff
Patch for landing (2.21 KB, patch)
2021-01-13 11:11 PST, John Wilander 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description John Wilander 2021-01-12 16:54:01 PST 
Experimental features on iOS use the prefix "WebKitExperimental." We should read it that way.
Comment 1 Radar WebKit Bug Importer 2021-01-12 16:55:05 PST 
<rdar://problem/73092137>
Comment 2 John Wilander 2021-01-12 16:59:31 PST 
Created attachment 417499 [details]
Patch
Comment 3 Brent Fulgham 2021-01-13 09:43:19 PST 
Comment on attachment 417499 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=417499&action=review

r=me

> Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm:497
> +#if PLATFORM(IOS)

I would suggest #elif PLATFORM(IOS).

> Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm:498
> +    parameters.enablePrivateClickMeasurementDebugMode = [defaults boolForKey:[NSString stringWithFormat:@"WebKitExperimental%@", WebPreferencesKey::privateClickMeasurementDebugModeEnabledKey().createCFString().get()]];

Sometimes we do #else with a "notImplemented()" but it's probably not warranted in this case.
Comment 4 John Wilander 2021-01-13 11:11:50 PST 
Created attachment 417549 [details]
Patch for landing
Comment 5 John Wilander 2021-01-13 11:14:07 PST 
Thanks, Brent!
Comment 6 EWS 2021-01-13 11:42:35 PST 
Committed r271448: <https://trac.webkit.org/changeset/271448>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 417549 [details].