The GitHub API has limitations without credentials. In many cases, this is fine, but we're going to need credentialed API access to manipulate pull-requests.
<rdar://problem/73063457>
Created attachment 417486 [details] Patch
Comment on attachment 417486 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=417486&action=review > Tools/Scripts/libraries/webkitscmpy/webkitscmpy/remote/git_hub.py:118 > + username, access_token = self.credentials(required=True if authenticated else False) required=bool(authenticated) ?
r=me
Created attachment 417664 [details] Patch for landing
Committed r271506: <https://trac.webkit.org/changeset/271506> All reviewed patches have been landed. Closing bug and clearing flags on attachment 417664 [details].
Reopening to attach new patch.
Created attachment 417795 [details] Patch
Created attachment 417797 [details] Patch for landing
(In reply to Jonathan Bedard from comment #9) > Created attachment 417797 [details] > Patch for landing keyring needs to be in the autoinstall mapping for webkitpy.
Committed r271569: <https://trac.webkit.org/changeset/271569> All reviewed patches have been landed. Closing bug and clearing flags on attachment 417797 [details].
Looks like it broke Ubuntu 18.04 WPE build[1]. xmltodict version is hardcoded to 0.12.0 but ubuntu 18 has only 0.11.0. [1] https://build.webkit.org/builders/WPE-Linux-64bit-Release-Packaging-Nightly-Ubuntu1804/builds/150/steps/generate-minibrowser-bundle/logs/stdio [2] https://github.com/WebKit/WebKit/blob/3b144366ff153f35e1cb334c0fe5f46bb4f216cd/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py#L55
Created attachment 418198 [details] Patch
(In reply to Yury Semikhatsky from comment #12) > Looks like it broke Ubuntu 18.04 WPE build[1]. xmltodict version is > hardcoded to 0.12.0 but ubuntu 18 has only 0.11.0. > > > [1] > https://build.webkit.org/builders/WPE-Linux-64bit-Release-Packaging-Nightly- > Ubuntu1804/builds/150/steps/generate-minibrowser-bundle/logs/stdio > > [2] > https://github.com/WebKit/WebKit/blob/ > 3b144366ff153f35e1cb334c0fe5f46bb4f216cd/Tools/Scripts/libraries/webkitscmpy/ > webkitscmpy/__init__.py#L55 Uploading a change that uses xmltodict 0.11.0
Committed r271768: <https://trac.webkit.org/changeset/271768> All reviewed patches have been landed. Closing bug and clearing flags on attachment 418198 [details].