Bug 220552 – [ Big Sur ] media/media-source/media-source-webm-init-inside-segment.html is failing

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Truitt Savell]

media/media-source/media-source-webm-init-inside-segment.html

This test is failing constantly on Big Sur

History:
https://results.webkit.org/?suite=layout-tests&test=media%2Fmedia-source%2Fmedia-source-webm-init-inside-segment.html

Diff:
--- /Volumes/Data/slave/bigsur-release-tests-wk2/build/layout-test-results/media/media-source/media-source-webm-init-inside-segment-expected.txt
+++ /Volumes/Data/slave/bigsur-release-tests-wk2/build/layout-test-results/media/media-source/media-source-webm-init-inside-segment-actual.txt
@@ -5,15 +5,6 @@
 RUN(source.duration = loader.duration())
 RUN(sourceBuffer = source.addSourceBuffer(loader.type()))
 RUN(sourceBuffer.appendBuffer(loader.initSegment()))
-EVENT(update)
-Append a media segment.
-RUN(sourceBuffer.appendBuffer(loader.mediaSegment(0)))
-EVENT(update)
-Append a new Initialization Segment.
-RUN(sourceBuffer.appendBuffer(loader.initSegment()))
-EVENT(update)
-Append a media segment.
-RUN(sourceBuffer.appendBuffer(loader.mediaSegment(1)))
-EVENT(update)
+EVENT(error) TEST(false) FAIL
 END OF TEST

[Radar WebKit Bug Importer]

<rdar://problem/73048070>

[Truitt Savell]

This test began showing in history after the changes in r271039

[Truitt Savell]

marked as failing in https://trac.webkit.org/changeset/271412/webkit

[Jean-Yves Avenard [:jya]]

Created attachment 418590 [details]
Patch

[Jean-Yves Avenard [:jya]]

Created attachment 418594 [details]
Patch

[Jean-Yves Avenard [:jya]]

Created attachment 418617 [details]
Add commit log into ChangeLog (I had it in the git commit before and it got lost when uploaded)

[EWS]

Tools/Scripts/svn-apply failed to apply attachment 418617 [details] to trunk.
Please resolve the conflicts and upload a new patch.

[Jean-Yves Avenard [:jya]]

Created attachment 418687 [details]
Patch for landing

[EWS]

Committed r272043: <https://trac.webkit.org/changeset/272043>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 418687 [details].

[Amir Mark Jr]

*** Bug 221426 has been marked as a duplicate of this bug. ***

[Truitt Savell]

This change https://trac.webkit.org/changeset/272043/webkit

did not fix the test. it is still failing.

History:
https://results.webkit.org/?suite=layout-tests&test=media%2Fmedia-source%2Fmedia-source-webm-init-inside-segment.html

[Truitt Savell]

Diff has changed:

--- /Volumes/Data/slave/bigsur-release-tests-wk1/build/layout-test-results/media/media-source/media-source-webm-init-inside-segment-expected.txt
+++ /Volumes/Data/slave/bigsur-release-tests-wk1/build/layout-test-results/media/media-source/media-source-webm-init-inside-segment-actual.txt
@@ -4,16 +4,9 @@
 EVENT(sourceopen)
 RUN(source.duration = loader.duration())
 RUN(sourceBuffer = source.addSourceBuffer(loader.type()))
+NotSupportedError: The operation is not supported.
 RUN(sourceBuffer.appendBuffer(loader.initSegment()))
-EVENT(update)
-Append a media segment.
-RUN(sourceBuffer.appendBuffer(loader.mediaSegment(0)))
-EVENT(update)
-Append a new Initialization Segment.
-RUN(sourceBuffer.appendBuffer(loader.initSegment()))
-EVENT(update)
-Append a media segment.
-RUN(sourceBuffer.appendBuffer(loader.mediaSegment(1)))
-EVENT(update)
+TypeError: undefined is not an object (evaluating 'sourceBuffer.appendBuffer')
+Caught exception: "TypeError: undefined is not an object (evaluating 'element.addEventListener')" FAIL
 END OF TEST

[Ryan Haddad]

(In reply to Truitt Savell from comment #11)
> This change https://trac.webkit.org/changeset/272043/webkit
> 
> did not fix the test. it is still failing.
> 
> History:
> https://results.webkit.org/?suite=layout-tests&test=media%2Fmedia-
> source%2Fmedia-source-webm-init-inside-segment.html
It looks like the change fixed the test for WK2, but it continues to fail on WK1.

Should we just be disabling all these webm tests on WK1 as won't fix, or are they expected to work?

[Ryan Haddad]

(In reply to Ryan Haddad from comment #13)
> (In reply to Truitt Savell from comment #11)
> > This change https://trac.webkit.org/changeset/272043/webkit
> > 
> > did not fix the test. it is still failing.
> > 
> > History:
> > https://results.webkit.org/?suite=layout-tests&test=media%2Fmedia-
> > source%2Fmedia-source-webm-init-inside-segment.html
> It looks like the change fixed the test for WK2, but it continues to fail on
> WK1.
> 
> Should we just be disabling all these webm tests on WK1
Skipped in r272818