Bug 220550 - REGRESSION (r267571): black line appears upon navigating back from apple.com shopping bag
Summary: REGRESSION (r267571): black line appears upon navigating back from apple.com ...
Alias: None
Product: WebKit
Classification: Unclassified
Component: Animations (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antoine Quint
Keywords: InRadar
Depends on:
Reported: 2021-01-12 10:44 PST by Antoine Quint
Modified: 2021-01-13 02:11 PST (History)
8 users (show)

See Also:

Patch (9.84 KB, patch)
2021-01-12 11:03 PST, Antoine Quint
no flags Details | Formatted Diff | Diff
Patch (12.41 KB, patch)
2021-01-12 12:13 PST, Antoine Quint
koivisto: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2021-01-12 10:44:08 PST
Steps to reproduce on iOS:

1. Open Safari
2. Navigate to apple.com
3. Tap on the shopping bag icon in the top right
4. Tap on the Bag item in the list
5. Wait for the next page to load
6. Navigate back to the previous page

At this point you'll notice a black line appearing in the menu. Prior to r267571, there wouldn't be one.
Comment 1 Antoine Quint 2021-01-12 10:44:23 PST
Comment 2 Antoine Quint 2021-01-12 11:03:28 PST
Created attachment 417472 [details]
Comment 3 Antoine Quint 2021-01-12 12:13:55 PST
Created attachment 417476 [details]
Comment 4 Antti Koivisto 2021-01-13 01:43:58 PST
Comment on attachment 417476 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=417476&action=review

Looks good

> Source/WebCore/dom/Element.cpp:3320
> +    if (pseudoId == PseudoId::None) {

I'd reverse the test so the main body of the function is the usual None case.
Comment 5 Antoine Quint 2021-01-13 02:11:35 PST
Committed r271435: <https://trac.webkit.org/changeset/271435>