Bug 220547 - [webkitcorepy] Add TaskPool
Summary: [webkitcorepy] Add TaskPool
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
: 220546 (view as bug list)
Depends on:
Blocks:
 
Reported: 2021-01-12 09:25 PST by Jonathan Bedard
Modified: 2021-10-01 12:46 PDT (History)
6 users (show)

See Also:

Attachments
Patch (21.54 KB, patch)
2021-01-12 09:27 PST, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Patch (21.64 KB, patch)
2021-01-12 09:35 PST, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Patch (21.67 KB, patch)
2021-01-19 07:53 PST, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Patch (22.14 KB, patch)
2021-01-20 11:27 PST, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Patch for landing (22.12 KB, patch)
2021-01-20 18:11 PST, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Patch for landing (2.09 KB, patch)
2021-10-01 11:48 PDT, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Show Obsolete (5) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2021-01-12 09:25:16 PST 
We need a multiprocessing architecture compatible with Python 3.8. Rather than attempt to retro-fit webkitpy's existing architecture, I think we should develop a new one to use going forward.
Comment 1 Radar WebKit Bug Importer 2021-01-12 09:26:10 PST 
<rdar://problem/73043887>
Comment 2 Jonathan Bedard 2021-01-12 09:27:53 PST 
Created attachment 417461 [details]
Patch
Comment 3 Jonathan Bedard 2021-01-12 09:35:52 PST 
Created attachment 417463 [details]
Patch
Comment 4 Alexey Proskuryakov 2021-01-12 17:54:39 PST 
*** Bug 220546 has been marked as a duplicate of this bug. ***
Comment 5 Jonathan Bedard 2021-01-19 07:53:12 PST 
Created attachment 417875 [details]
Patch
Comment 6 Jonathan Bedard 2021-01-20 11:27:08 PST 
Created attachment 417981 [details]
Patch
Comment 7 Jonathan Bedard 2021-01-20 11:29:46 PST 
(In reply to Jonathan Bedard from comment #6)
> Created attachment 417981 [details]
> Patch

Sam and I talked today, they had some good points, namely: Making the queue a class variable of Process may encourage future code to mess with the state of the TaskPool and ensuring that we don't encounter deadlocks when queues get full.
Comment 8 dewei_zhu 2021-01-20 14:40:29 PST 
r=me
Comment 9 Jonathan Bedard 2021-01-20 18:11:04 PST 
Created attachment 418010 [details]
Patch for landing
Comment 10 EWS 2021-01-20 18:51:30 PST 
Committed r271683: <https://trac.webkit.org/changeset/271683>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 418010 [details].
Comment 11 Aakash Jain 2021-01-21 04:13:50 PST 
Noticing ImportError (while importing six) after this, see: https://bugs.webkit.org/show_bug.cgi?id=220791
Comment 12 Jonathan Bedard 2021-10-01 11:48:24 PDT 
Reopening to attach new patch.
Comment 13 Jonathan Bedard 2021-10-01 11:48:25 PDT 
Created attachment 439886 [details]
Patch for landing
Comment 14 EWS 2021-10-01 12:46:11 PDT 
Committed r283391 (242395@main): <https://commits.webkit.org/242395@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 439886 [details].