Bug 220537 – Clean up some mainframe scroll snap tests

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Martin Robinson]

Some mainframe scroll snap tests include dead code and are written in a way that can hide some failures. This bug tracks cleaning up those tests.

[Martin Robinson]

Created attachment 417439 [details]
Patch

[Frédéric Wang (:fredw)]

Comment on attachment 417439 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=417439&action=review

> LayoutTests/tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-mainframe-horizontal-legacy.html:40
> +                expectTrue(document.scrollingElement.scrollLeft == window.innerWidth, "div honored snap points.");

This (and below) is no longer comparing against scrollPositionBeforeSnap == document.scrollingElement.scrollLeft ; is it intentional?

[Martin Robinson]

(In reply to Frédéric Wang (:fredw) from comment #2)
> Comment on attachment 417439 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=417439&action=review
> 
> > LayoutTests/tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-mainframe-horizontal-legacy.html:40
> > +                expectTrue(document.scrollingElement.scrollLeft == window.innerWidth, "div honored snap points.");
> 
> This (and below) is no longer comparing against scrollPositionBeforeSnap ==
> document.scrollingElement.scrollLeft ; is it intentional?

Yes, instead of sampling the scroll position before the tests, the code now relies on all scroll positions being fixed values. This should always be the case. In this way the tests are a little stronger, I think.

[Frédéric Wang (:fredw)]

Comment on attachment 417439 [details]
Patch

OK, maybe worth explaining it in the changelog?

[Martin Robinson]

Created attachment 417456 [details]
Patch

[Martin Robinson]

(In reply to Frédéric Wang (:fredw) from comment #4)
> Comment on attachment 417439 [details]
> Patch
> 
> OK, maybe worth explaining it in the changelog?

Sure. I've updated the ChangeLog now.

[EWS]

Committed r271403: <https://trac.webkit.org/changeset/271403>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 417456 [details].

[Radar WebKit Bug Importer]

<rdar://problem/73041906>