Bug 22053 - add initial support for the NPDrawingModelCoreAnimation drawing model.
Summary: add initial support for the NPDrawingModelCoreAnimation drawing model.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Plug-ins (show other bugs)
Version: 528+ (Nightly build)
Hardware: Macintosh OS X 10.5
: P2 Major
Assignee: Kevin Decker
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-11-03 12:16 PST by Kevin Decker
Modified: 2008-11-24 09:23 PST (History)
0 users

See Also:


Attachments
patch (10.65 KB, patch)
2008-11-03 12:39 PST, Kevin Decker
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kevin Decker 2008-11-03 12:16:12 PST
This patch adds initial support for the NPDrawingModelCoreAnimation drawing model. 
                
        * Plugins/WebBaseNetscapePluginView.h: Added _layer ivar.
        * Plugins/WebBaseNetscapePluginView.mm:
        (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]): ASSERT this is not a plug-in using NPDrawingModelCoreAnimation.
        (-[WebBaseNetscapePluginView restorePortState:]): Ditto.
        (-[WebBaseNetscapePluginView sendEvent:isDrawRect:]): Slightly refactored a small block of code which with the PortState.
        Plug-ins using the NPDrawingModelCoreAnimation drawing model have no PortState. 
        (-[WebBaseNetscapePluginView isNewWindowEqualToOldWindow]): ASSERT this is not a plug-in using NPDrawingModelCoreAnimation
        (-[WebBaseNetscapePluginView updateAndSetWindow]):  Ditto.
        (-[WebBaseNetscapePluginView setWindowIfNecessary]): Ditto.
        (-[WebBaseNetscapePluginView start]): If the plug-in is a plug-in using the Core Animation model, request a layer from it.
        (-[WebBaseNetscapePluginView drawRect:]): Return early for NPDrawingModelCoreAnimation plug-ins.
        (-[WebBaseNetscapePluginView getVariable:value:]): Tell plug-ins running on post-Tiger systems WebKit supports
         NPDrawingModelCoreAnimation.
        (-[WebBaseNetscapePluginView setVariable:value:]): Added the new NPDrawingModelCoreAnimation case, which initializes drawingMode.
        (-[WebBaseNetscapePluginView _viewHasMoved]): Reworded the conditional call to updateAndSetWindow to be specific to 
        CoreGraphics and QuickDraw plug-ins.
Comment 1 Kevin Decker 2008-11-03 12:39:50 PST
Created attachment 24862 [details]
patch
Comment 2 Kevin Decker 2008-11-03 12:53:53 PST
Committed revision 38078.
Comment 3 Kevin Decker 2008-11-03 12:54:32 PST
Reviewed by Anders.
Comment 4 Adam Roben (:aroben) 2008-11-24 09:23:11 PST
Comment on attachment 24862 [details]
patch

Clearing review flag since this was landed.