RESOLVED FIXED 22053
add initial support for the NPDrawingModelCoreAnimation drawing model.
https://bugs.webkit.org/show_bug.cgi?id=22053
Summary add initial support for the NPDrawingModelCoreAnimation drawing model.
Kevin Decker
Reported 2008-11-03 12:16:12 PST
This patch adds initial support for the NPDrawingModelCoreAnimation drawing model. * Plugins/WebBaseNetscapePluginView.h: Added _layer ivar. * Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]): ASSERT this is not a plug-in using NPDrawingModelCoreAnimation. (-[WebBaseNetscapePluginView restorePortState:]): Ditto. (-[WebBaseNetscapePluginView sendEvent:isDrawRect:]): Slightly refactored a small block of code which with the PortState. Plug-ins using the NPDrawingModelCoreAnimation drawing model have no PortState. (-[WebBaseNetscapePluginView isNewWindowEqualToOldWindow]): ASSERT this is not a plug-in using NPDrawingModelCoreAnimation (-[WebBaseNetscapePluginView updateAndSetWindow]): Ditto. (-[WebBaseNetscapePluginView setWindowIfNecessary]): Ditto. (-[WebBaseNetscapePluginView start]): If the plug-in is a plug-in using the Core Animation model, request a layer from it. (-[WebBaseNetscapePluginView drawRect:]): Return early for NPDrawingModelCoreAnimation plug-ins. (-[WebBaseNetscapePluginView getVariable:value:]): Tell plug-ins running on post-Tiger systems WebKit supports NPDrawingModelCoreAnimation. (-[WebBaseNetscapePluginView setVariable:value:]): Added the new NPDrawingModelCoreAnimation case, which initializes drawingMode. (-[WebBaseNetscapePluginView _viewHasMoved]): Reworded the conditional call to updateAndSetWindow to be specific to CoreGraphics and QuickDraw plug-ins.
Attachments
patch (10.65 KB, patch)
2008-11-03 12:39 PST, Kevin Decker
no flags
Kevin Decker
Comment 1 2008-11-03 12:39:50 PST
Kevin Decker
Comment 2 2008-11-03 12:53:53 PST
Committed revision 38078.
Kevin Decker
Comment 3 2008-11-03 12:54:32 PST
Reviewed by Anders.
Adam Roben (:aroben)
Comment 4 2008-11-24 09:23:11 PST
Comment on attachment 24862 [details] patch Clearing review flag since this was landed.
Note You need to log in before you can comment on or make changes to this bug.