REOPENED 220527
fast/hidpi and svg/filters/hidpi don't run in hidpi mode 
https://bugs.webkit.org/show_bug.cgi?id=220527
Summary fast/hidpi and svg/filters/hidpi don't run in hidpi mode
Simon Fraser (smfr)
Reported 2021-01-11 15:40:56 PST
Testing code does: static std::optional<double> overrideDeviceScaleFactorForTest(const std::string& pathOrURL) { if (pathContains(pathOrURL, "/hidpi-3x-")) return 3; if (pathContains(pathOrURL, "/hidpi-")) return 2; return std::nullopt; } but those directories don't match.
Attachments
Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2021-01-11 16:42:34 PST
As far as I can tell, this has always been the case. At least some of those tests use testRunner.setBackingScaleFactor. Note that even though the quoted code is from TestRunnerShared, DumpRenderTree has a copy of this logic.
Radar WebKit Bug Importer
Comment 2 2021-01-18 15:41:13 PST
<rdar://problem/73331633>
Alexey Proskuryakov
Comment 3 2021-01-20 14:16:34 PST
I'll say "behaves correctly", please feel free to reopen if you disagree.
Simon Fraser (smfr)
Comment 4 2021-01-20 14:35:08 PST
There are tests in those directories that are obviously written with the assumption that they are running in hidpi, so something needs to change.
Note You need to log in before you can comment on or make changes to this bug.