Bug 220516 - AX: Implement aria-braillelabel and aria-brailleroledescription
Summary: AX: Implement aria-braillelabel and aria-brailleroledescription
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: chris fleizach
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-01-11 10:48 PST by James Craig
Modified: 2021-01-18 19:18 PST (History)
14 users (show)

See Also:


Attachments
patch (10.76 KB, patch)
2021-01-11 15:37 PST, chris fleizach
no flags Details | Formatted Diff | Diff
patch (11.84 KB, patch)
2021-01-12 09:28 PST, chris fleizach
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
patch (12.25 KB, patch)
2021-01-12 09:41 PST, chris fleizach
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Comment 1 Radar WebKit Bug Importer 2021-01-11 10:48:37 PST
<rdar://problem/73004715>
Comment 2 chris fleizach 2021-01-11 15:37:44 PST
Created attachment 417416 [details]
patch
Comment 3 Andres Gonzalez 2021-01-11 18:30:23 PST
(In reply to chris fleizach from comment #2)
> Created attachment 417416 [details]
> patch

diff --git a/Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp b/Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp
index 50ce8b6af26b..1a991833828f 100644
--- a/Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp
+++ b/Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp
@@ -237,0 +238,2 @@ void AXIsolatedObject::initializeAttributeData(AXCoreObject& object, bool isRoot
+    setProperty(AXPropertyName::BrailleRoleDescription, object.brailleRoleDescription());
+    setProperty(AXPropertyName::BrailleLabel, object.brailleLabel());

isolatedCopy() both Strings.
Comment 4 Andres Gonzalez 2021-01-11 18:31:50 PST
The test can be moved as is to LayoutTests/accessibility so that it runs in both MacOS and iOS. We would have to exclude it from GTK and Win.
Comment 5 chris fleizach 2021-01-12 09:28:03 PST
Created attachment 417462 [details]
patch

Addressed comments, Andres
Comment 6 chris fleizach 2021-01-12 09:41:23 PST
Created attachment 417465 [details]
patch
Comment 7 EWS 2021-01-12 14:13:32 PST
Committed r271416: <https://trac.webkit.org/changeset/271416>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 417465 [details].