Bug 220492 – TypedArray's [[DefineOwnProperty]] should throw in case of failure

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Alexey Shvayka]

TypedArray's [[DefineOwnProperty]] should throw in case of failure

[Alexey Shvayka]

Created attachment 417324 [details]
Patch

[Darin Adler]

Comment on attachment 417324 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=417324&action=review

> Source/JavaScriptCore/runtime/JSGenericTypedArrayViewInlines.h:409
> +            typename Adaptor::Type value = toNativeFromValue<Adaptor>(globalObject, descriptor.value());

Do we really need Adaptor::Type here. Would auto work?

[Radar WebKit Bug Importer]

<rdar://problem/73271007>

[Alexey Shvayka]

Created attachment 421957 [details]
Patch

Adjust tests and don't throw if the buffer was detached during the coercion.

[Alexey Shvayka]

(In reply to Darin Adler from comment #2)

Thank you for review!

> Do we really need Adaptor::Type here. Would auto work?

I've reverted this bit as it was spec-incorrect: in a very unlike case of [[Value]] coercion detaching the buffer, we should silently ignore it.

[Alexey Shvayka]

Created attachment 421963 [details]
Patch

Fix unchecked exception.

[EWS]

Committed r273750: <https://commits.webkit.org/r273750>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 421963 [details].