WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
REOPENED
Bug 220468
[webkitcorepy] Add standard mechanism for packaging pip packages
https://bugs.webkit.org/show_bug.cgi?id=220468
Summary
[webkitcorepy] Add standard mechanism for packaging pip packages
Jonathan Bedard
Reported
2021-01-08 10:40:06 PST
All of our pip packages based on webkitcorepy share some key pieces in common. Most notably, we've attempted to de-duplicate the version of a pip package from setup.py and the __init__.py of the package. This means that we attempt to import from a package before we've actually installed it's dependencies, which can be a problem. The right solution to this is probably to edit the contents of setup.py to replace the imported version with a it's value before deploying the package, but that means having a script to do the package deployment. In the mean time, we need to duplicate the version for our pip packages to make them easier to independently install.
Attachments
Patch
(6.57 KB, patch)
2021-01-08 10:53 PST
,
Jonathan Bedard
no flags
Details
Formatted Diff
Diff
Patch
(16.90 KB, patch)
2021-05-03 13:49 PDT
,
Jonathan Bedard
jbedard
: review?
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2021-01-08 10:40:41 PST
<
rdar://problem/72935720
>
Jonathan Bedard
Comment 2
2021-01-08 10:53:49 PST
Created
attachment 417277
[details]
Patch
EWS
Comment 3
2021-01-08 11:34:41 PST
Committed
r271306
: <
https://trac.webkit.org/changeset/271306
> All reviewed patches have been landed. Closing bug and clearing flags on
attachment 417277
[details]
.
Jonathan Bedard
Comment 4
2021-01-08 11:35:27 PST
The change landed in this patch just works-around the problem, it doesn't resolve it.
Jonathan Bedard
Comment 5
2021-05-03 13:49:54 PDT
Created
attachment 427599
[details]
Patch
Jonathan Bedard
Comment 6
2021-05-03 13:55:11 PDT
Still some work to do to make this compatible with Artifactory, but this lays out the mechanics I had in mind for standardizing our packaging mechanics
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug