Bug 220435 - PlaybackSessionManager::m_clientCounts is not updated correctly when a video enters picture-in-picture from fullscreen
Summary: PlaybackSessionManager::m_clientCounts is not updated correctly when a video ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Peng Liu
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-01-07 14:16 PST by Peng Liu
Modified: 2021-01-08 14:45 PST (History)
7 users (show)

See Also:

Attachments
Patch (2.41 KB, patch)
2021-01-07 14:25 PST, Peng Liu 		eric.carlson: review+
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch for landing (2.40 KB, patch)
2021-01-07 14:37 PST, Peng Liu 		no flags Details | Formatted Diff | Diff
Patch (5.10 KB, patch)
2021-01-08 12:05 PST, Peng Liu 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Peng Liu 2021-01-07 14:16:46 PST 
PlaybackSessionManager::m_clientCounts is not updated correctly when a video enters picture-in-picture from fullscreen
Comment 1 Peng Liu 2021-01-07 14:22:31 PST 
<rdar://problem/70749570>
Comment 2 Peng Liu 2021-01-07 14:25:41 PST 
Created attachment 417212 [details]
Patch
Comment 3 Eric Carlson 2021-01-07 14:33:58 PST 
Comment on attachment 417212 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=417212&action=review

> Source/WebKit/ChangeLog:11
> +        because `m_clientCounts` has been updated when the video enters fullscreen.

s/has been updated when the video enters/was updated when the video entered/
Comment 4 Peng Liu 2021-01-07 14:37:48 PST 
Created attachment 417213 [details]
Patch for landing
Comment 5 EWS 2021-01-07 16:31:03 PST 
Committed r271273: <https://trac.webkit.org/changeset/271273>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 417213 [details].
Comment 6 Peng Liu 2021-01-08 12:05:43 PST 
Reopening to attach new patch.
Comment 7 Peng Liu 2021-01-08 12:05:44 PST 
Created attachment 417288 [details]
Patch
Comment 8 EWS 2021-01-08 14:45:41 PST 
Committed r271325: <https://trac.webkit.org/changeset/271325>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 417288 [details].