Bug 220429 – [JSC] New expression and value function call should reserve function register if arguments include assignments

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Yusuke Suzuki]

[JSC] New expression and value function call should reserve function register if arguments include assignments

[Yusuke Suzuki]

Created attachment 417200 [details]
Patch

[Yusuke Suzuki]

Created attachment 417204 [details]
Patch

[Yusuke Suzuki]

<rdar://problem/70598359>

[Alexey Shvayka]

Comment on attachment 417204 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=417204&action=review

This is handsome, nicely done!

> Source/JavaScriptCore/ChangeLog:17
> +            2. function value call (it is checking `isLocation()`, but we can still use local variables for function if we use comma expression)

Tagged template literals are already correct:

    x`_${x = 1}_`

Would be nice to have a test for it (if there is none).

[Yusuke Suzuki]

Comment on attachment 417204 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=417204&action=review

I'll fix some of tests (the tests themselves are wrong).

>> Source/JavaScriptCore/ChangeLog:17
>> +            2. function value call (it is checking `isLocation()`, but we can still use local variables for function if we use comma expression)
> 
> Tagged template literals are already correct:
> 
>     x`_${x = 1}_`
> 
> Would be nice to have a test for it (if there is none).

Sounds good!

[Yusuke Suzuki]

Created attachment 417206 [details]
Patch

[Yusuke Suzuki]

Created attachment 417207 [details]
Patch

[EWS]

Committed r271265: <https://trac.webkit.org/changeset/271265>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 417207 [details].

[Yusuke Suzuki]

*** Bug 217308 has been marked as a duplicate of this bug. ***