ASSERTION FAILED: source
Created attachment 24854 [details]
My C++-foo isn't strong enough to know exactly why this was wrong, but this stops the ASSERT.
Comment on attachment 24854 [details]
r=me if you change the parameters on the other two constructors in that file to match.
This is a pretty bizarre thing. I wish I knew why it happened.
Committed revision 38068.
Doesn't this mean that all the name changes in http://trac.webkit.org/changeset/38066 are invalid?
The name changes are valid. The issue was that after the initializer
the PassRefPtr source was getting zeroed out, causing the assertion that source is nonzero to fail, where source is scoped to the parameter rather than the member variable. The assertion could also have been changed to ASSERT(this->source), and I might go back and do that.