Bug 220397 - The scratch register should be different from the target register when calling validateUntaggedPtr.
Summary: The scratch register should be different from the target register when callin...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-01-06 21:11 PST by Mark Lam
Modified: 2021-01-09 08:53 PST (History)
8 users (show)

See Also:


Attachments
proposed patch. (2.29 KB, patch)
2021-01-06 21:20 PST, Mark Lam
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2021-01-06 21:11:11 PST
rdar://72771069
Comment 1 Mark Lam 2021-01-06 21:20:16 PST
Created attachment 417152 [details]
proposed patch.
Comment 2 Yusuke Suzuki 2021-01-06 21:22:44 PST
Comment on attachment 417152 [details]
proposed patch.

r=me
Comment 3 Mark Lam 2021-01-07 09:02:41 PST
Comment on attachment 417152 [details]
proposed patch.

Thanks for the review.  Landing now.
Comment 4 EWS 2021-01-07 09:33:29 PST
Committed r271240: <https://trac.webkit.org/changeset/271240>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 417152 [details].
Comment 5 zalan 2021-01-09 04:24:09 PST
I can still repro the crash with the most recent spade (r271343).
Comment 6 Mark Lam 2021-01-09 08:53:38 PST
(In reply to zalan from comment #5)
> I can still repro the crash with the most recent spade (r271343).

This turns out to be a different issue.  We should track it with a new bug.  Closing this one.