RESOLVED FIXED Bug 220381
Use sendWithAsyncReply instead of dataCallback for icon loading 
https://bugs.webkit.org/show_bug.cgi?id=220381
Summary Use sendWithAsyncReply instead of dataCallback for icon loading
Alex Christensen
Reported 2021-01-06 13:19:44 PST
Use sendWithAsyncReply instead of dataCallback for icon loading
Attachments
Patch (33.27 KB, patch)
2021-01-06 13:27 PST, Alex Christensen 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (33.51 KB, patch)
2021-01-06 13:34 PST, Alex Christensen 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (33.54 KB, patch)
2021-01-06 14:01 PST, Alex Christensen 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (34.92 KB, patch)
2021-01-06 14:06 PST, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (35.22 KB, patch)
2021-01-06 16:40 PST, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (33.76 KB, patch)
2021-01-11 13:00 PST, Alex Christensen 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2021-01-06 13:27:59 PST
Created attachment 417122 [details] Patch
Alex Christensen
Comment 2 2021-01-06 13:34:03 PST
Created attachment 417124 [details] Patch
Alex Christensen
Comment 3 2021-01-06 14:01:53 PST
Created attachment 417127 [details] Patch
Alex Christensen
Comment 4 2021-01-06 14:06:16 PST
Created attachment 417128 [details] Patch
EWS Watchlist
Comment 5 2021-01-06 14:06:57 PST
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See https://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Alex Christensen
Comment 6 2021-01-06 16:40:11 PST
Created attachment 417139 [details] Patch
youenn fablet
Comment 7 2021-01-11 04:56:07 PST
Comment on attachment 417139 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=417139&action=review > Source/WebCore/loader/DocumentLoader.cpp:327 > + callback(nullptr); Can callback modify m_iconLoaders? Given we do m_iconLoaders.clear() below, can we do a std::exchange? > Source/WebCore/loader/DocumentLoader.cpp:2193 > + m_iconLoaders.set(WTFMove(iconLoader), WTFMove(completionHandler)); s/set/add/
Alex Christensen
Comment 8 2021-01-11 13:00:35 PST
Created attachment 417405 [details] Patch
EWS
Comment 9 2021-01-11 13:36:46 PST
Committed r271378: <https://trac.webkit.org/changeset/271378> All reviewed patches have been landed. Closing bug and clearing flags on attachment 417405 [details].
Radar WebKit Bug Importer
Comment 10 2021-01-11 13:37:17 PST
<rdar://problem/73011806>
Alex Christensen
Comment 11 2021-01-11 15:30:43 PST
http://trac.webkit.org/r271383
Note You need to log in before you can comment on or make changes to this bug.