Bug 220376 - [macOS] Text inside form controls is off center on burton.com
Summary: [macOS] Text inside form controls is off center on burton.com
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: Other
Hardware: Unspecified macOS 11
: P2 Normal
Assignee: Aditya Keerthi
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-01-06 11:51 PST by Aditya Keerthi
Modified: 2021-01-06 15:46 PST (History)
11 users (show)

See Also:

Attachments
Screenshot (27.97 KB, image/png)
2021-01-06 11:51 PST, Aditya Keerthi 		no flags Details
Patch (4.52 KB, patch)
2021-01-06 11:54 PST, Aditya Keerthi 		hi: review+
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch for landing (5.01 KB, patch)
2021-01-06 12:42 PST, Aditya Keerthi 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Aditya Keerthi 2021-01-06 11:51:40 PST 
Created attachment 417109 [details]
Screenshot

Observed when interacting with <select> elements in Burton's checkout flow.
Comment 1 Aditya Keerthi 2021-01-06 11:54:07 PST 
Created attachment 417110 [details]
Patch
Comment 2 Aditya Keerthi 2021-01-06 11:56:17 PST 
<rdar://problem/72833977>
Comment 3 Devin Rousso 2021-01-06 11:59:22 PST 
Comment on attachment 417110 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=417110&action=review

r=me

> Source/WebCore/css/html.css:1017
> +select:matches([size=""], [size="0"], [size="1"]) {

NIT: should we change this to `:is` while we're at it?
Comment 4 Aditya Keerthi 2021-01-06 12:42:14 PST 
Created attachment 417115 [details]
Patch for landing
Comment 5 EWS 2021-01-06 15:45:57 PST 
Committed r271218: <https://trac.webkit.org/changeset/271218>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 417115 [details].