[WASM-References] Add linking tests
Created attachment 416979 [details] Patch
Comment on attachment 416979 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=416979&action=review r=me, but we need to have bugzilla links. > JSTests/wasm/references-spec-tests/linking.wast.js:269 > +// FIXME: should be uninstantiable - https://github.com/WebAssembly/bulk-memory-operations/issues/133. should be uninstantiable - https://github.com/WebAssembly/bulk-memory-operations/issues/133. When commenting out wasm spec test, we should have bugzilla URL with FIXME which clarifies what is the problem and how we will fix in the future. And the comment has duplicate information twice. > JSTests/wasm/references-spec-tests/linking.wast.js:279 > +// FIXME: should be uninstantiable - https://github.com/WebAssembly/bulk-memory-operations/issues/133. Ditto. > JSTests/wasm/references-spec-tests/linking.wast.js:290 > +// FIXME: should be uninstantiable - https://github.com/WebAssembly/bulk-memory-operations/issues/133. Ditto. > JSTests/wasm/references-spec-tests/linking.wast.js:353 > +// FIXME: should be uninstantiable - https://github.com/WebAssembly/bulk-memory-operations/issues/133. Ditto. > JSTests/wasm/references-spec-tests/linking.wast.js:391 > +// FIXME: should be uninstantiable - https://github.com/WebAssembly/bulk-memory-operations/issues/133. Ditto. > JSTests/wasm/references-spec-tests/linking.wast.js:402 > +// FIXME: should be uninstantiable - https://github.com/WebAssembly/bulk-memory-operations/issues/133. Ditto.
Created attachment 417245 [details] Patch
Committed r271300: <https://trac.webkit.org/changeset/271300> All reviewed patches have been landed. Closing bug and clearing flags on attachment 417245 [details].
<rdar://problem/72932205>