Bug 220259 - [LFC][IFC] Do not use LineBox::isConsideredEmpty when checking if inline box stretches the line box
Summary: [LFC][IFC] Do not use LineBox::isConsideredEmpty when checking if inline box ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-01-04 19:28 PST by zalan
Modified: 2021-01-16 06:28 PST (History)
5 users (show)

See Also:

Attachments
Patch (13.53 KB, patch)
2021-01-04 19:34 PST, zalan 		no flags Details | Formatted Diff | Diff
Patch (13.54 KB, patch)
2021-01-10 20:16 PST, zalan 		no flags Details | Formatted Diff | Diff
Patch (13.54 KB, patch)
2021-01-13 09:53 PST, zalan 		no flags Details | Formatted Diff | Diff
Patch (8.65 KB, patch)
2021-01-14 06:58 PST, zalan 		no flags Details | Formatted Diff | Diff
Patch (10.17 KB, patch)
2021-01-15 20:37 PST, zalan 		no flags Details | Formatted Diff | Diff
Patch (10.15 KB, patch)
2021-01-15 20:43 PST, zalan 		no flags Details | Formatted Diff | Diff
Patch (10.50 KB, patch)
2021-01-15 21:40 PST, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (6) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2021-01-04 19:28:12 PST 
e.g. <!DOCTYPE html><span><div></div></span> the pre and post blocks 

block container (pre)
 inline box
block container
block container (post)
  inline box
-no struts in these generated content.
Comment 1 zalan 2021-01-04 19:34:37 PST 
Created attachment 416970 [details]
Patch
Comment 2 zalan 2021-01-10 20:16:26 PST 
Created attachment 417360 [details]
Patch
Comment 3 Antti Koivisto 2021-01-10 22:28:07 PST 
Comment on attachment 417360 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=417360&action=review

> Source/WebCore/layout/inlineformatting/InlineLineBuilder.h:-60
> -        bool isLineConsideredEmpty { true };

Nice
Comment 4 Radar WebKit Bug Importer 2021-01-11 19:29:13 PST 
<rdar://problem/73023402>
Comment 5 zalan 2021-01-13 09:53:59 PST 
Created attachment 417542 [details]
Patch
Comment 6 zalan 2021-01-14 06:58:17 PST 
Created attachment 417617 [details]
Patch
Comment 7 zalan 2021-01-15 20:37:39 PST 
Created attachment 417757 [details]
Patch
Comment 8 zalan 2021-01-15 20:43:29 PST 
Created attachment 417758 [details]
Patch
Comment 9 zalan 2021-01-15 21:40:27 PST 
Created attachment 417761 [details]
Patch
Comment 10 EWS 2021-01-16 06:28:43 PST 
Committed r271555: <https://trac.webkit.org/changeset/271555>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 417761 [details].