Bug 220250 – [WebXR][WPE] Build fails without openxr installed

• Status: RESOLVED
• Resolution: FIXED
• Component: WebXR

[Lauro Moura]

The WPE Nightly Packaging bot is failing as WebXR is enabled (through ENABLE_EXPERIMENTAL_FEATURES) but openxr is not installed by jhbuild.

Also, instead of failing early, it fails late in the compilation after r270067 changed some defines.

[Lauro Moura]

Created attachment 416958 [details]
Patch

[Carlos Alberto Lopez Perez]

Comment on attachment 416958 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=416958&action=review

> Tools/jhbuild/jhbuild-minimal.modules:125
> +  <cmake id="openxr">

Please add here below a pkg-config line like this:
<pkg-config>openxr.pc</pkg-config>

This will tell JHBuild to only build openxr if the system doesn't have it already installed

[Lauro Moura]

Created attachment 416964 [details]
Patch for landing

[EWS]

Committed r271138: <https://trac.webkit.org/changeset/271138>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 416964 [details].

[Yury Semikhatsky]

Looks like this broke jhbuild-minimal, I get a bunch of errors like this on Ubuntu 20.04:

*** Building openxr *** [4/5]                                                                                                                                                                                                                                                     
ninja                                                                                                                                                                                                                                                                             
[3/18] Building C object src/loader/CMakeFiles/openxr_loader.dir/__/xr_generated_dispatch_table.c.o                                                                                                                                                                               
FAILED: src/loader/CMakeFiles/openxr_loader.dir/__/xr_generated_dispatch_table.c.o                                                                                                                                                                                                
/usr/lib/ccache/cc -DAPI_NAME=\"OpenXR\" -DDISABLE_STD_FILESYSTEM -DEXTRASYSCONFDIR=\"/etc\" -DFALLBACK_CONFIG_DIRS=\"/etc/xdg\" -DFALLBACK_DATA_DIRS=\"/usr/local/share:/usr/share\" -DOPENXR_HAVE_COMMON_CONFIG -DSYSCONFDIR=\"/home/yurys/playwright/browser_patches/webkit/che
ckout/WebKitBuild/WPE/DependenciesWPE/Root/etc\" -DXRAPI_DLL_EXPORT -DXR_OS_LINUX -DXR_USE_GRAPHICS_API_OPENGL -DXR_USE_PLATFORM_WAYLAND -DXR_USE_PLATFORM_XCB -DXR_USE_PLATFORM_XLIB -DXR_USE_TIMESPEC -Dopenxr_loader_EXPORTS -I/home/yurys/playwright/browser_patches/webkit/ch
eckout/WebKitBuild/WPE/DependenciesWPE/Source/openxr-1.0.11/src/../include -I/home/yurys/playwright/browser_patches/webkit/checkout/WebKitBuild/WPE/DependenciesWPE/Source/openxr-1.0.11/src -I/home/yurys/playwright/browser_patches/webkit/checkout/WebKitBuild/WPE/Dependencies
WPE/Source/openxr-1.0.11/src/external/jsoncpp/include -I/home/yurys/playwright/browser_patches/webkit/checkout/WebKitBuild/WPE/DependenciesWPE/Source/openxr-1.0.11/src/common -I/home/yurys/playwright/browser_patches/webkit/checkout/WebKitBuild/WPE/DependenciesWPE/Source/ope
nxr-1.0.11/include -Iinclude -I/home/yurys/playwright/browser_patches/webkit/checkout/WebKitBuild/WPE/DependenciesWPE/Source/openxr-1.0.11/src/loader/.. -Isrc/loader/.. -I/home/yurys/playwright/browser_patches/webkit/checkout/WebKitBuild/WPE/DependenciesWPE/Source/openxr-1.
0.11/src/loader -Isrc/loader -Wall -Werror=unused-parameter -Werror=unused-argument -Wpointer-arith -fPIC -fvisibility=hidden   -Wno-unused-parameter -Wextra -fno-strict-aliasing -fno-builtin-memcmp -ffunction-sections -fdata-sections -MD -MT src/loader/CMakeFiles/openxr_lo
ader.dir/__/xr_generated_dispatch_table.c.o -MF src/loader/CMakeFiles/openxr_loader.dir/__/xr_generated_dispatch_table.c.o.d -o src/loader/CMakeFiles/openxr_loader.dir/__/xr_generated_dispatch_table.c.o   -c /home/yurys/playwright/browser_patches/webkit/checkout/WebKitBuild
/WPE/DependenciesWPE/Source/openxr-1.0.11/src/xr_generated_dispatch_table.c
In file included from /home/yurys/playwright/browser_patches/webkit/checkout/WebKitBuild/WPE/DependenciesWPE/Source/openxr-1.0.11/src/xr_generated_dispatch_table.c:26:                                                                                                           
In file included from /home/yurys/playwright/browser_patches/webkit/checkout/WebKitBuild/WPE/DependenciesWPE/Source/openxr-1.0.11/src/xr_generated_dispatch_table.h:27:                                                                                                           
/home/yurys/playwright/browser_patches/webkit/checkout/WebKitBuild/WPE/DependenciesWPE/Source/openxr-1.0.11/src/common/xr_dependencies.h:83:10: fatal error: 'xcb/glx.h' file not found                                                                                           
#include <xcb/glx.h>                                                                                                                                                                                                                                                              
         ^~~~~~~~~~~                                                                                                                                                                                                                                                              
1 error generated.

[Yury Semikhatsky]

Created attachment 417039 [details]
Patch

[Lauro Moura]

Created attachment 446586 [details]
[fast-cq] Updated patch after rebase

[EWS]

Committed r286797 (245037@main): <https://commits.webkit.org/245037@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 446586 [details].