Bug 220249 - [LFC][Integration] Factor marked text style collection code out of InlineTextBox
Summary: [LFC][Integration] Factor marked text style collection code out of InlineTextBox
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-01-04 10:43 PST by Antti Koivisto
Modified: 2021-01-11 09:39 PST (History)
16 users (show)

See Also:


Attachments
patch (23.27 KB, patch)
2021-01-04 10:46 PST, Antti Koivisto
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
patch (28.21 KB, patch)
2021-01-04 11:41 PST, Antti Koivisto
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
patch (33.57 KB, patch)
2021-01-05 07:18 PST, Antti Koivisto
zalan: review+
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
patch (31.92 KB, patch)
2021-01-10 05:42 PST, Antti Koivisto
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2021-01-04 10:43:50 PST
So we can teach LFC to paint selections and other marked text.
Comment 1 Antti Koivisto 2021-01-04 10:46:06 PST
Created attachment 416956 [details]
patch
Comment 2 Antti Koivisto 2021-01-04 11:41:22 PST
Created attachment 416957 [details]
patch
Comment 3 Antti Koivisto 2021-01-05 07:18:14 PST
Created attachment 417002 [details]
patch
Comment 4 zalan 2021-01-05 11:05:46 PST
Comment on attachment 417002 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=417002&action=review

> Source/WebCore/rendering/MarkedTextStyle.h:57
> +    float alpha;

hope this never leads to random alpha.
Comment 5 EWS 2021-01-10 03:56:35 PST
Tools/Scripts/svn-apply failed to apply attachment 417002 [details] to trunk.
Please resolve the conflicts and upload a new patch.
Comment 6 Antti Koivisto 2021-01-10 05:42:55 PST
Created attachment 417348 [details]
patch
Comment 7 EWS 2021-01-10 10:09:14 PST
Committed r271350: <https://trac.webkit.org/changeset/271350>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 417348 [details].
Comment 8 Radar WebKit Bug Importer 2021-01-10 10:10:20 PST
<rdar://problem/72976067>
Comment 9 Antti Koivisto 2021-01-11 09:39:22 PST
Build fix https://trac.webkit.org/changeset/271364/webkit