Bug 22024 - Assertion Failure: !m_singlePageGroup in Page::initGroup
Summary: Assertion Failure: !m_singlePageGroup in Page::initGroup
Status: RESOLVED DUPLICATE of bug 22966
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on:
Blocks:
 
Reported: 2008-10-31 19:12 PDT by Jan Alonzo
Modified: 2009-02-17 11:50 PST (History)
2 users (show)

See Also:


Attachments
check if we have a group before adding a group profile to the window (1.29 KB, patch)
2008-10-31 19:38 PDT, Jan Alonzo
darin: review-
Details | Formatted Diff | Diff
test case (123 bytes, text/plain)
2008-11-02 10:20 PST, Jan Alonzo
no flags Details
backtrace (5.51 KB, text/plain)
2008-11-23 22:15 PST, Jan Alonzo
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Alonzo 2008-10-31 19:12:24 PDT
r37922 exposed a bug in ScriptController::clearWindowShell where the call to page->group() initializes the group eventhough we're still in the process of destroying the page and its resources (there shouldn't be a group anymore but group() creates one if there is none).

I have attached a fix which just adds the group if we have a groupName. Question is can a valid group be empty?

I think clearWindowShell() is confusing since instead of just clearing the window, it just replaces it with a new one - see changeset r32585.
Comment 1 Jan Alonzo 2008-10-31 19:38:31 PDT
Created attachment 24830 [details]
check if we have a group before adding a group profile to the window
Comment 2 Holger Freyther 2008-11-02 09:44:55 PST
Could you create a test case that is showing this issue? E.g. when running the prepare-ChangeLog script one should see the warning in capital letters, we should start to take that warning serious.
Comment 3 Jan Alonzo 2008-11-02 10:20:00 PST
Created attachment 24848 [details]
test case

(In reply to comment #2)
> Could you create a test case that is showing this issue? E.g. when running the
> prepare-ChangeLog script one should see the warning in capital letters, we
> should start to take that warning serious.

Sure. Please see attached. Thanks for reminding me =)
Comment 4 Holger Freyther 2008-11-03 08:04:02 PST
Hmm... I don't see it. Do you still get it on a clean rebuild? I open the file in DumpRenderTree and GtkLauncher and have a ToT build.
Comment 5 Jan Alonzo 2008-11-23 22:15:10 PST
Created attachment 25412 [details]
backtrace
Comment 6 Jan Alonzo 2008-11-24 01:52:02 PST
Hi Sam! The patch attached herein is just a workaround. The assertion was triggered due to another gtk bug whereby we are not calling FrameLoader::detachFromParent on WebView destruction (like mac does).

Anyway, comment #1 should explain what I think is the issue here. I'm not familiar with that part of WebCore yet so any feedback would be appreciated.

Thanks!
Comment 7 Darin Adler 2008-12-05 09:34:50 PST
Comment on attachment 24830 [details]
check if we have a group before adding a group profile to the window

If this is a workaround for a GTK-specific bug, then I don't think it should be added unconditionally for all platforms. There's nothing in the patch that explains this.

And whether or not this is a workaround for a GTK-specific bug, then I'd like to see the test case included with the bug fix in a single patch.

review- for now until this minor business is resolved.
Comment 8 Holger Freyther 2009-02-09 12:50:28 PST
Do we still need that? The ref counting fixes for WebFrame and WebView might/should have fixed it.
Comment 9 Jan Alonzo 2009-02-09 13:09:06 PST
(In reply to comment #8)
> Do we still need that? The ref counting fixes for WebFrame and WebView
> might/should have fixed it.
> 

Zecke, I'm still getting this error even after the webframe/webview leak fix.
Comment 10 Gustavo Noronha (kov) 2009-02-10 12:16:16 PST
I promise I did search for this bug to no avail. Should enhance my bug searching skill, I guess. I reported a related bug, with a different fix here as https://bugs.webkit.org/show_bug.cgi?id=22966.
Comment 11 Jan Alonzo 2009-02-17 11:50:32 PST

*** This bug has been marked as a duplicate of 22966 ***