Bug 220236 - WebKit IPC generator tests have duplicate receiver names, limiting the implementation
Summary: WebKit IPC generator tests have duplicate receiver names, limiting the implem...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Local Build
Hardware: All All
: P2 Minor
Assignee: Kimmo Kinnunen
URL:
Keywords: InRadar
Depends on:
Blocks: webglgpup 220318
  Show dependency tree / graph
 
Reported: 2021-01-04 03:20 PST by Kimmo Kinnunen
Modified: 2021-01-05 16:46 PST (History)
2 users (show)

See Also:

Attachments
Patch (257.64 KB, patch)
2021-01-04 05:50 PST, Kimmo Kinnunen 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kimmo Kinnunen 2021-01-04 03:20:39 PST 
WebKit IPC generator tests have duplicate receiver names, limiting the implementation

This is a problem because in real world usage, all the receiver names need to be unique.

The in the test content, there is 3 different receivers receivers. They also share names of the messages.
These distinct messages get assigned the same message name, even though the messages themselves are distinct and have different receivers and maybe arguments.
Comment 1 Kimmo Kinnunen 2021-01-04 05:50:07 PST 
Created attachment 416935 [details]
Patch
Comment 2 Chris Dumez 2021-01-05 12:19:58 PST 
Comment on attachment 416935 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=416935&action=review

r=me

> Source/WebKit/Scripts/MessageNames.h:-31
> -enum class ReceiverName : uint8_t {

Having WebPage 3 times in this enum indeed seemed bogus.
Comment 3 EWS 2021-01-05 16:45:18 PST 
Committed r271183: <https://trac.webkit.org/changeset/271183>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 416935 [details].
Comment 4 Radar WebKit Bug Importer 2021-01-05 16:46:16 PST 
<rdar://problem/72834703>