Bug 220235 - [WASM-References] Fix data section parsing and add more tests from ref-types
Summary: [WASM-References] Fix data section parsing and add more tests from ref-types
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-01-04 02:48 PST by Dmitry
Modified: 2021-01-04 21:03 PST (History)
8 users (show)

See Also:

Attachments
Patch (400.79 KB, patch)
2021-01-04 02:55 PST, Dmitry 		no flags Details | Formatted Diff | Diff
Patch (400.68 KB, patch)
2021-01-04 20:11 PST, Dmitry 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitry 2021-01-04 02:48:18 PST 
[WASM-References] Fix data section parsing and add more tests from ref-types
Comment 1 Dmitry 2021-01-04 02:55:13 PST 
Created attachment 416931 [details]
Patch
Comment 2 Yusuke Suzuki 2021-01-04 10:04:40 PST 
Comment on attachment 416931 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=416931&action=review

r=me with comment.

> Source/JavaScriptCore/wasm/WasmSectionParser.cpp:747
> +        const char* errorMessage = Options::useWebAssemblyReferences() ? "th Data segment's flag" : "th Data segment's index";

I think we should just throw an error with `"th Data segment's flag"`.
Comment 3 Dmitry 2021-01-04 20:11:20 PST 
Created attachment 416971 [details]
Patch
Comment 4 EWS 2021-01-04 21:02:02 PST 
Committed r271141: <https://trac.webkit.org/changeset/271141>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 416971 [details].
Comment 5 Radar WebKit Bug Importer 2021-01-04 21:03:16 PST 
<rdar://problem/72802112>