Bug 220210 - [LFC Display] Give display boxes a parent pointer
Summary: [LFC Display] Give display boxes a parent pointer
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-12-31 08:57 PST by Simon Fraser (smfr)
Modified: 2021-01-04 10:16 PST (History)
4 users (show)

See Also:

Attachments
Patch (2.59 KB, patch)
2020-12-31 08:57 PST, Simon Fraser (smfr) 		zalan: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2020-12-31 08:57:09 PST 
[LFC Display] Give display boxes a parent pointer
Comment 1 Simon Fraser (smfr) 2020-12-31 08:57:54 PST 
Created attachment 416866 [details]
Patch
Comment 2 zalan 2021-01-02 20:09:38 PST 
Comment on attachment 416866 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=416866&action=review

> Source/WebCore/display/css/DisplayBox.h:73
> +    ContainerBox* parent() const { return m_parent; }

I usually do a const and a non-const version of getters like this (unless you really only need a const ContainerBox* parent())
Comment 3 Simon Fraser (smfr) 2021-01-04 10:15:21 PST 
https://trac.webkit.org/r271134
Comment 4 Radar WebKit Bug Importer 2021-01-04 10:16:36 PST 
<rdar://problem/72794178>