Bug 22020 - Basic windows types (RECT, POINT, etc) should be guarded by WIN_OS instead of WIN
Summary: Basic windows types (RECT, POINT, etc) should be guarded by WIN_OS instead of...
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-10-31 15:36 PDT by Eric Seidel (no email)
Modified: 2022-09-29 18:14 PDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2008-10-31 15:36:48 PDT 
Basic windows types (RECT, POINT, etc) should be guarded by WIN_OS instead of WIN

We don't actually use them in Chromium (I don't think), but we probably should (instead of our own custom conversion functions).

I guess that means we'd have a platform/graphics/win_os then to hold IntRectWinOS, etc?  Or maybe it can just stay in win/ (which I think I'd prefer).
Comment 1 Dave Hyatt 2008-10-31 15:38:04 PDT 
I think it should just stay in win/.  If Chromium has to dip into that dir for a couple of files that's fine.
Comment 2 Ahmad Saleem 2022-09-23 18:03:53 PDT 
ap@webkit.org - Is it something we need today? Thanks!
Comment 3 Alexey Proskuryakov 2022-09-29 18:14:41 PDT 
No, it's just a refactoring that was under consideration in 2008 (and rejected even then).