WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED WONTFIX
22020
Basic windows types (RECT, POINT, etc) should be guarded by WIN_OS instead of WIN
https://bugs.webkit.org/show_bug.cgi?id=22020
Summary
Basic windows types (RECT, POINT, etc) should be guarded by WIN_OS instead of...
Eric Seidel (no email)
Reported
2008-10-31 15:36:48 PDT
Basic windows types (RECT, POINT, etc) should be guarded by WIN_OS instead of WIN We don't actually use them in Chromium (I don't think), but we probably should (instead of our own custom conversion functions). I guess that means we'd have a platform/graphics/win_os then to hold IntRectWinOS, etc? Or maybe it can just stay in win/ (which I think I'd prefer).
Attachments
Add attachment
proposed patch, testcase, etc.
Dave Hyatt
Comment 1
2008-10-31 15:38:04 PDT
I think it should just stay in win/. If Chromium has to dip into that dir for a couple of files that's fine.
Ahmad Saleem
Comment 2
2022-09-23 18:03:53 PDT
ap@webkit.org
- Is it something we need today? Thanks!
Alexey Proskuryakov
Comment 3
2022-09-29 18:14:41 PDT
No, it's just a refactoring that was under consideration in 2008 (and rejected even then).
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug