Bug 220179 - Share meta refresh logic
Summary: Share meta refresh logic
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Rob Buis
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-12-27 08:13 PST by Rob Buis
Modified: 2021-01-03 06:42 PST (History)
7 users (show)

See Also:

Attachments
Patch (4.97 KB, patch)
2020-12-27 08:15 PST, Rob Buis 		no flags Details | Formatted Diff | Diff
Patch (5.14 KB, patch)
2021-01-03 03:21 PST, Rob Buis 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Rob Buis 2020-12-27 08:13:02 PST 
Share meta refresh logic between Document and FrameLoader.
Comment 1 Rob Buis 2020-12-27 08:15:12 PST 
Created attachment 416822 [details]
Patch
Comment 2 Darin Adler 2021-01-02 16:03:58 PST 
Comment on attachment 416822 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=416822&action=review

> Source/WebCore/ChangeLog:8
> +        Share meta refresh logic between Document and FrameLoader.

This change is great; two copies seems silly!

Bigger picture, long ago we tried to break apart Document and Frame so they wouldn’t be super-huge "god objects", something we got part way through and never finished. I worry that code moving from FrameLoader to Frame and Document starts to undo that.
Comment 3 Rob Buis 2021-01-03 03:21:22 PST 
Created attachment 416909 [details]
Patch
Comment 4 EWS 2021-01-03 05:48:15 PST 
Committed r271125: <https://trac.webkit.org/changeset/271125>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 416909 [details].
Comment 5 Radar WebKit Bug Importer 2021-01-03 05:49:16 PST 
<rdar://problem/72776134>
Comment 6 Rob Buis 2021-01-03 06:42:10 PST 
Comment on attachment 416822 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=416822&action=review

>> Source/WebCore/ChangeLog:8
>> +        Share meta refresh logic between Document and FrameLoader.
> 
> This change is great; two copies seems silly!
> 
> Bigger picture, long ago we tried to break apart Document and Frame so they wouldn’t be super-huge "god objects", something we got part way through and never finished. I worry that code moving from FrameLoader to Frame and Document starts to undo that.

Thanks for that reminder! Based on that, I moved the new method to FrameLoader instead of Document.