Bug 220158 - Assorted fixes for bisect-builds
Summary: Assorted fixes for bisect-builds
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
Keywords: InRadar
Depends on:
Reported: 2020-12-26 13:14 PST by Alexey Proskuryakov
Modified: 2021-01-06 12:31 PST (History)
3 users (show)

See Also:

proposed patch (22.78 KB, patch)
2020-12-26 13:15 PST, Alexey Proskuryakov
no flags Details | Formatted Diff | Diff
proposed patch (22.77 KB, patch)
2021-01-06 09:21 PST, Alexey Proskuryakov
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2020-12-26 13:14:42 PST
bisect-builds doesn't work with Python 3, and is buggy in several ways.
Comment 1 Alexey Proskuryakov 2020-12-26 13:15:46 PST
Created attachment 416790 [details]
proposed patch
Comment 2 Radar WebKit Bug Importer 2021-01-02 13:15:15 PST
Comment 3 Jonathan Bedard 2021-01-05 10:27:28 PST
Comment on attachment 416790 [details]
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=416790&action=review

> Tools/Scripts/bisect-builds:209
> +    platform = SystemHost().platform

SystemHost is not free to instantiate (it runs some shell commands in the constructor, if I recall correctly), so we probably don't want to instantiate it twice.

> Tools/Scripts/bisect-builds:214
> +        return platform

Pretty sure you want to return "platform.os_name", not the actual PlatformInfo object
Comment 4 Alexey Proskuryakov 2021-01-06 09:21:38 PST
Created attachment 417092 [details]
proposed patch

Thank you, updated accordingly.
Comment 5 EWS 2021-01-06 12:31:49 PST
Committed r271211: <https://trac.webkit.org/changeset/271211>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 417092 [details].