Bug 220156 - Remove one more place needed when adding new color types
Summary: Remove one more place needed when adding new color types
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-12-26 11:58 PST by Sam Weinig
Modified: 2021-05-25 19:31 PDT (History)
3 users (show)

See Also:

Attachments
Patch (1.91 KB, patch)
2020-12-26 11:59 PST, Sam Weinig 		simon.fraser: review+
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
repro for the MSVC bug (1.78 KB, text/plain)
2020-12-26 14:43 PST, Fujii Hironori 		no flags Details
Try not using a template-template parameter (1.86 KB, patch)
2020-12-26 14:56 PST, Sam Weinig 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Another attempt (1.79 KB, patch)
2020-12-26 19:24 PST, Sam Weinig 		no flags Details | Formatted Diff | Diff
For landing. (4.06 KB, patch)
2020-12-26 20:28 PST, Sam Weinig 		no flags Details | Formatted Diff | Diff
For Landing. (4.06 KB, patch)
2020-12-26 20:40 PST, Sam Weinig 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2020-12-26 11:58:50 PST 
Remove one more place needed when adding new color types
Comment 1 Sam Weinig 2020-12-26 11:59:52 PST 
Created attachment 416787 [details]
Patch
Comment 2 Fujii Hironori 2020-12-26 14:43:12 PST 
Created attachment 416791 [details]
repro for the MSVC bug

This seems a MSVC bug. I can't find out any workaround. Will report to MSVC team.
Comment 3 Sam Weinig 2020-12-26 14:55:03 PST 
(In reply to Fujii Hironori from comment #2)
> Created attachment 416791 [details]
> repro for the MSVC bug
> 
> This seems a MSVC bug. I can't find out any workaround. Will report to MSVC
> team.

Crazy, thanks so much. Let me know what you hear.
Comment 4 Sam Weinig 2020-12-26 14:56:33 PST 
Created attachment 416792 [details]
Try not using a template-template parameter
Comment 5 Sam Weinig 2020-12-26 15:13:02 PST 
Comment on attachment 416792 [details]
Try not using a template-template parameter

Nope. Looks like that is far too permissive. Perhaps an std::enable_if can be used here.
Comment 6 Sam Weinig 2020-12-26 19:24:11 PST 
Created attachment 416794 [details]
Another attempt
Comment 7 Sam Weinig 2020-12-26 20:28:04 PST 
Created attachment 416796 [details]
For landing.
Comment 8 Sam Weinig 2020-12-26 20:40:09 PST 
Created attachment 416798 [details]
For Landing.
Comment 9 EWS 2020-12-27 10:00:37 PST 
Committed r271093: <https://trac.webkit.org/changeset/271093>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 416798 [details].
Comment 10 Radar WebKit Bug Importer 2020-12-27 10:01:19 PST 
<rdar://problem/72690546>
Comment 11 Fujii Hironori 2021-01-06 23:32:09 PST 
MSVC bug ticket: https://developercommunity2.visualstudio.com/t/template-specialization-reports-error-c2440-with-s/1296792

> A fix for this issue has been internally implemented and is being prepared for release. We’ll update you once it becomes available for download.
Comment 12 Fujii Hironori 2021-05-25 19:31:26 PDT 
(In reply to Fujii Hironori from comment #11)
> MSVC bug ticket:
> https://developercommunity2.visualstudio.com/t/template-specialization-reports-error-c2440-with-s/1296792
> 
> > A fix for this issue has been internally implemented and is being prepared for release. We’ll update you once it becomes available for download.

I got a report that Visual Studio 2019 version 16.10 fixed and I confirmed it fixed. BTW, I can't access the my MSVC bug ticket now.