Bug 220133 – Fail speech recognition when page is muted for audio capture

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Sihui Liu]

...

[Sihui Liu]

Created attachment 416734 [details]
Patch

[Radar WebKit Bug Importer]

<rdar://problem/72745232>

[Sihui Liu]

Created attachment 416973 [details]
Patch

[Sihui Liu]

Created attachment 416975 [details]
Patch

[youenn fablet]

Comment on attachment 416975 [details]
Patch

Looks good overall.
Some style improvements below.

View in context: https://bugs.webkit.org/attachment.cgi?id=416975&action=review

> Source/WebKit/ChangeLog:11
> +        1. when page is muted, mute audio capture source used for speech recognition audion on the page. This will

s/audion/audio/

> Source/WebKit/UIProcess/UserMediaProcessManager.cpp:73
> +    }

I am not sure we need to create a HashSet here.
We could either add a SpeechRecognitionPermissionManager::muteCaptureExceptIn(WebPageProxy&) or rely on WebProcessProxy::globalPageMap() and remove UserMediaProcessManager::muteCaptureMediaStreamsExceptIn

> Source/WebKit/UIProcess/WebProcessProxy.cpp:1779
> +    speechRecognitionServer->mute();

I would write it as if (auto ...)

[Sihui Liu]

(In reply to youenn fablet from comment #5)
> Comment on attachment 416975 [details]
> Patch
> 
> Looks good overall.
> Some style improvements below.

Thanks for review!

> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=416975&action=review
> 
> > Source/WebKit/ChangeLog:11
> > +        1. when page is muted, mute audio capture source used for speech recognition audion on the page. This will
> 
> s/audion/audio/
> 
> > Source/WebKit/UIProcess/UserMediaProcessManager.cpp:73
> > +    }
> 
> I am not sure we need to create a HashSet here.
> We could either add a
> SpeechRecognitionPermissionManager::muteCaptureExceptIn(WebPageProxy&) or
> rely on WebProcessProxy::globalPageMap() and remove
> UserMediaProcessManager::muteCaptureMediaStreamsExceptIn

Okay, removing UserMediaProcessManager::muteCaptureMediaStreamsExceptIn and add it in WebProcessProxy.

> 
> > Source/WebKit/UIProcess/WebProcessProxy.cpp:1779
> > +    speechRecognitionServer->mute();
> 
> I would write it as if (auto ...)

[Sihui Liu]

Created attachment 417013 [details]
Patch for landing

[EWS]

Committed r271154: <https://trac.webkit.org/changeset/271154>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 417013 [details].