WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
220126
[GPU Process]: Don't call flushDrawingContext() in the middle of recording drawing commands
https://bugs.webkit.org/show_bug.cgi?id=220126
Summary
[GPU Process]: Don't call flushDrawingContext() in the middle of recording dr...
Said Abou-Hallawa
Reported
2020-12-23 11:18:42 PST
Before using a single shared memory buffer for sending the DL items from WebP to GPUP, calling flushDrawingContext() was necessary to synchronize multiple ImageBuffers drawing. The single shared memory buffer guarantees the order of drawing is preserved even when an ImageBuffer is drawn into another ImageBuffer. So flushDrawingContext() should be called only when the drawing is finished and the backend of the ImageBuffer is about to be used.
Attachments
Patch
(7.18 KB, patch)
2020-12-23 11:29 PST
,
Said Abou-Hallawa
simon.fraser
: review+
Details
Formatted Diff
Diff
Patch
(9.19 KB, patch)
2020-12-23 12:09 PST
,
Said Abou-Hallawa
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Said Abou-Hallawa
Comment 1
2020-12-23 11:19:16 PST
<
rdar://problem/72394086
>
Said Abou-Hallawa
Comment 2
2020-12-23 11:29:35 PST
Created
attachment 416720
[details]
Patch
Wenson Hsieh
Comment 3
2020-12-23 11:33:41 PST
Comment on
attachment 416720
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=416720&action=review
> Source/WebCore/ChangeLog:8 > + Avoid calling lushDrawingContext() except when the drawing is finished
Nit - flushDrawingContext()
> Source/WebCore/platform/graphics/displaylists/DisplayListRecorder.cpp:-185 > - imageBuffer.flushDrawingContext();
Just to confirm — we don't need to call CGContextFlush for the previous canvas's remote image buffer either?
> Source/WebKit/WebProcess/GPU/graphics/RemoteImageBufferProxy.h:-387 > - size_t m_itemCountInCurrentDisplayList { 0 };
Nice.
Simon Fraser (smfr)
Comment 4
2020-12-23 11:42:57 PST
Comment on
attachment 416720
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=416720&action=review
>> Source/WebCore/platform/graphics/displaylists/DisplayListRecorder.cpp:-185 >> - imageBuffer.flushDrawingContext(); > > Just to confirm — we don't need to call CGContextFlush for the previous canvas's remote image buffer either?
CG should take care of flushing when drawing one IOSurface-based CGContext into another.
Said Abou-Hallawa
Comment 5
2020-12-23 12:09:15 PST
Created
attachment 416722
[details]
Patch
Said Abou-Hallawa
Comment 6
2020-12-23 12:11:59 PST
***
Bug 219558
has been marked as a duplicate of this bug. ***
EWS
Comment 7
2020-12-23 13:58:03 PST
Committed
r271079
: <
https://trac.webkit.org/changeset/271079
> All reviewed patches have been landed. Closing bug and clearing flags on
attachment 416722
[details]
.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug