Bug 220123 - Use sendWithAsyncReply instead of FontAttributesCallback
Summary: Use sendWithAsyncReply instead of FontAttributesCallback
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-12-23 10:36 PST by Alex Christensen
Modified: 2021-01-05 10:42 PST (History)
2 users (show)

See Also:


Attachments
Patch (8.68 KB, patch)
2020-12-23 10:36 PST, Alex Christensen
no flags Details | Formatted Diff | Diff
Patch (8.65 KB, patch)
2020-12-23 10:40 PST, Alex Christensen
no flags Details | Formatted Diff | Diff
Patch (8.81 KB, patch)
2021-01-05 09:45 PST, Alex Christensen
no flags Details | Formatted Diff | Diff
Patch (8.22 KB, patch)
2021-01-05 10:33 PST, Alex Christensen
cdumez: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2020-12-23 10:36:30 PST
Use sendWithAsyncReply instead of FontAttributesCallback
Comment 1 Alex Christensen 2020-12-23 10:36:44 PST
Created attachment 416714 [details]
Patch
Comment 2 Alex Christensen 2020-12-23 10:40:19 PST
Created attachment 416715 [details]
Patch
Comment 3 Radar WebKit Bug Importer 2020-12-30 10:37:12 PST
<rdar://problem/72742140>
Comment 4 Chris Dumez 2021-01-05 08:40:42 PST
Comment on attachment 416715 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=416715&action=review

> Source/WebKit/UIProcess/WebPageProxy.cpp:-2360
> -    m_cachedFontAttributesAtSelectionStart = attributes;

Looks like you are no longer updating m_cachedFontAttributesAtSelectionStart ?
Comment 5 Alex Christensen 2021-01-05 09:45:05 PST
Created attachment 417012 [details]
Patch
Comment 6 Alex Christensen 2021-01-05 10:33:29 PST
Created attachment 417019 [details]
Patch
Comment 7 Alex Christensen 2021-01-05 10:42:17 PST
http://trac.webkit.org/r271160