Bug 220117 - [WPE][GTK] Remove webkit_web_context_set_sandbox_enabled() from modern API
Summary: [WPE][GTK] Remove webkit_web_context_set_sandbox_enabled() from modern API
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: PC Linux
: P2 Normal
Assignee: Michael Catanzaro
URL:
Keywords:
Depends on: 249034
Blocks: GTK4
  Show dependency tree / graph
 
Reported: 2020-12-23 05:36 PST by Michael Catanzaro
Modified: 2023-01-18 08:10 PST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Catanzaro 2020-12-23 05:36:25 PST 
webkit_web_context_set_sandbox_enabled() should not exist in the GTK 4 API. The sandbox should always be enabled, with no API function to disable it.
Comment 1 Michael Catanzaro 2021-10-27 18:48:36 PDT 
One more thing: we should crash if the application tries to allowlist / or /home or $HOME. We cannot prevent apps from allowlisting whatever they wish, but if they want to be stupid they should have to try somewhat harder than that.
Comment 2 Michael Catanzaro 2022-04-08 07:26:40 PDT 
Let's provide an environment variable as an out: disabling the sandbox is very useful for debugging purposes. But it should be much scarier than the current WEBKIT_FORCE_SANDBOX=0. I would name it WEBKIT_ALLOW_HACKING_ME=1 or something like that.
Comment 3 Michael Catanzaro 2022-10-30 09:17:40 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/5944
Comment 4 EWS 2023-01-18 08:10:50 PST 
Committed 259028@main (0f14b00d81e3): <https://commits.webkit.org/259028@main>

Reviewed commits have been landed. Closing PR #5944 and removing active labels.