Bug 220087 – [GStreamer] Add support to build with native audio and video

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Xabier Rodríguez Calvar]

[GStreamer] Add support to build with native audio and video

[Xabier Rodríguez Calvar]

Created attachment 416666 [details]
Patch

[Xabier Rodríguez Calvar]

Comment on attachment 416666 [details]
Patch

I should polish this by adding more checks on GStreamer and tweaking defaults.

[Xabier Rodríguez Calvar]

Created attachment 417262 [details]
Patch

[Philippe Normand]

Comment on attachment 417262 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=417262&action=review

> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:2698
> +#if ENABLE(TEXT_SINK)
> +    unsigned hasText = getGstPlayFlag("text");
> +#else
> +    unsigned hasText = 0x0;
> +#endif

What's the implication of disabling this in playbin? In the player we set a custom text-sink to collect in-band text cues, should that code be ifdeffed now?

[Xabier Rodríguez Calvar]

(In reply to Philippe Normand from comment #4)
> Comment on attachment 417262 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=417262&action=review
> 
> > Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:2698
> > +#if ENABLE(TEXT_SINK)
> > +    unsigned hasText = getGstPlayFlag("text");
> > +#else
> > +    unsigned hasText = 0x0;
> > +#endif
> 
> What's the implication of disabling this in playbin? In the player we set a
> custom text-sink to collect in-band text cues, should that code be ifdeffed
> now?

Text sink pads get not connected to anything in playsink so text dies there.

[Philippe Normand]

Comment on attachment 417262 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=417262&action=review

> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:2714
> +    g_object_set(pipeline, "flags", hasText | hasAudio | hasVideo | hasNativeVideo | hasNativeAudio, nullptr);

So this unsets the default flags too, which is not a great idea, the default is "soft-colorbalance+deinterlace+soft-volume+text+audio+video". Can you get the previous flags before and preserve them please?

[Xabier Rodríguez Calvar]

Created attachment 417269 [details]
Patch

[EWS]

Committed r271355: <https://trac.webkit.org/changeset/271355>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 417269 [details].

[Radar WebKit Bug Importer]

<rdar://problem/72990488>