Bug 220075 - Layout overflow is computed incorrectly inside flexbox (breaks sticky positioning)
Summary: Layout overflow is computed incorrectly inside flexbox (breaks sticky positio...
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
Keywords: InRadar
Depends on:
Reported: 2020-12-21 15:42 PST by Simon Fraser (smfr)
Modified: 2020-12-22 08:09 PST (History)
12 users (show)

See Also:

Testcase (683 bytes, text/html)
2020-12-21 15:42 PST, Simon Fraser (smfr)
no flags Details
Patch (4.64 KB, patch)
2020-12-21 19:58 PST, Simon Fraser (smfr)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2020-12-21 15:42:07 PST
Created attachment 416639 [details]

In the attached testcase, the sticky element gets pushed out of view as you scroll down and should not.

In RenderBoxModelObject::computeStickyPositionConstraints(), containingBlock->layoutOverflowRect() returns a rect that is too short, but only when inside flex layout.
Comment 1 Simon Fraser (smfr) 2020-12-21 15:43:00 PST
Comment 2 Simon Fraser (smfr) 2020-12-21 19:58:36 PST
Created attachment 416648 [details]
Comment 3 EWS 2020-12-22 08:09:28 PST
Committed r271053: <https://trac.webkit.org/changeset/271053>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 416648 [details].