Bug 220058 – Unmuting a track in case of end of interruption by another web process tab is not working well with capture muting icons

• Status: REOPENED
• Component: WebRTC

[youenn fablet]

Unmuting a track in case of end of interruption by another web process tab is not working well with capture muting icons

[youenn fablet]

Created attachment 416606 [details]
Patch

[Radar WebKit Bug Importer]

<rdar://problem/72705675>

[youenn fablet]

Created attachment 416998 [details]
Patch

[Eric Carlson]

Comment on attachment 416998 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=416998&action=review

> Source/WebCore/ChangeLog:20
> +        When an interruption ends, all capture tracks are updated accorsing the page muted state, which is controlled by UIProcess.

s/updated accorsing the page/updated according to the page/

> Source/WebKit/ChangeLog:172
> -2020-12-22  Youenn Fablet  <[e-mail]>
> [phone]  Youenn Fablet  <[e-mail]>

Is this change intentional?

> Source/WebCore/Modules/mediastream/MediaStreamTrack.cpp:487
> +        // We can only have one source at a time: we can mute all tracks but unmute only one of them.

Nit: this and the comment below are duplicated in the audio and video loops, they could be moved up above instead.

[youenn fablet]

Created attachment 417445 [details]
Patch for landing

[EWS]

Committed r271401: <https://trac.webkit.org/changeset/271401>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 417445 [details].

[WebKit Commit Bot]

Re-opened since this is blocked by bug 220591