Bug 220052 - [Cocoa] RuntimeEnabledFeatures shouldn't be used from inside of /platform
Summary: [Cocoa] RuntimeEnabledFeatures shouldn't be used from inside of /platform
Status: RESOLVED CONFIGURATION CHANGED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Carlson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-12-20 22:06 PST by Eric Carlson
Modified: 2021-01-06 10:10 PST (History)
7 users (show)

See Also:


Attachments
Patch (12.90 KB, patch)
2020-12-20 22:14 PST, Eric Carlson
dbates: review+
ews-feeder: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Carlson 2020-12-20 22:06:33 PST
RuntimeEnabledFeatures shouldn't be used from inside of /platform
Comment 1 Radar WebKit Bug Importer 2020-12-20 22:06:45 PST
<rdar://problem/72539739>
Comment 2 Eric Carlson 2020-12-20 22:14:53 PST
Created attachment 416594 [details]
Patch
Comment 3 Daniel Bates 2020-12-21 23:12:41 PST
Comment on attachment 416594 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=416594&action=review

> Source/WebCore/platform/audio/PlatformMediaSessionManager.h:210
> +    static bool m_webMFormatReaderEnabled;

Ok as is. New C++17 hotness: mark inline + add initializer.
Comment 4 Eric Carlson 2021-01-06 10:10:32 PST
This was rolled into r271194.