Bug 220047 - Simplify CARingBuffer usage with SharedMemory storage
Summary: Simplify CARingBuffer usage with SharedMemory storage
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-12-20 15:56 PST by Chris Dumez
Modified: 2020-12-21 15:09 PST (History)
8 users (show)

See Also:

Attachments
Patch (24.52 KB, patch)
2020-12-20 16:02 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (24.72 KB, patch)
2020-12-21 12:09 PST, Chris Dumez 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2020-12-20 15:56:30 PST 
Simplify CARingBuffer usage with SharedMemory storage.
Comment 1 Chris Dumez 2020-12-20 16:02:31 PST 
Created attachment 416589 [details]
Patch
Comment 2 Geoffrey Garen 2020-12-21 10:18:39 PST 
Comment on attachment 416589 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=416589&action=review

r=me

> Source/WebKit/Shared/Cocoa/SharedRingBufferStorage.cpp:40
> +void* ReadOnlySharedRingBufferStorage::data()

const void*?

> Source/WebKit/Shared/Cocoa/SharedRingBufferStorage.cpp:45
> +auto ReadOnlySharedRingBufferStorage::sharedFrameBounds() const -> FrameBounds*

const FrameBounds*?
Comment 3 Chris Dumez 2020-12-21 12:09:59 PST 
Created attachment 416617 [details]
Patch
Comment 4 EWS 2020-12-21 14:32:02 PST 
Committed r271041: <https://trac.webkit.org/changeset/271041>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 416617 [details].
Comment 5 Radar WebKit Bug Importer 2020-12-21 14:33:30 PST 
<rdar://problem/72562577>