Bug 220014 - [macOS] Deny mach-lookup to the service 'com.apple.iconservices.store' in the WebContent process
Summary: [macOS] Deny mach-lookup to the service 'com.apple.iconservices.store' in the...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Per Arne Vollan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-12-18 06:51 PST by Per Arne Vollan
Modified: 2021-01-23 07:35 PST (History)
3 users (show)

See Also:


Attachments
Patch (4.16 KB, patch)
2020-12-18 06:56 PST, Per Arne Vollan
no flags Details | Formatted Diff | Diff
Patch (6.42 KB, patch)
2020-12-18 11:52 PST, Per Arne Vollan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Per Arne Vollan 2020-12-18 06:51:21 PST
Deny mach-lookup to the service 'com.apple.iconservices.store' in the WebContent process on macOS, since there are no longer any reports of this service being used.
Comment 1 Per Arne Vollan 2020-12-18 06:51:38 PST
<rdar://problem/68923110>
Comment 2 Per Arne Vollan 2020-12-18 06:56:09 PST
Created attachment 416515 [details]
Patch
Comment 3 Alexey Proskuryakov 2020-12-18 07:28:58 PST
Comment on attachment 416515 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=416515&action=review

> Source/WebKit/ChangeLog:10
> +        since there are no longer any reports of this being used.

Out of curiosity, how do we get icons for file input form controls now?
Comment 4 Per Arne Vollan 2020-12-18 11:08:18 PST
(In reply to Alexey Proskuryakov from comment #3)
> Comment on attachment 416515 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=416515&action=review
> 
> > Source/WebKit/ChangeLog:10
> > +        since there are no longer any reports of this being used.
> 
> Out of curiosity, how do we get icons for file input form controls now?

We are creating extensions for the open file dialog. Is that the case you’re thinking of?

Thanks for reviewing!
Comment 5 Per Arne Vollan 2020-12-18 11:52:07 PST
Created attachment 416538 [details]
Patch
Comment 6 Alexey Proskuryakov 2020-12-18 12:06:52 PST
> We are creating extensions for the open file dialog. Is that the case you’re
> thinking of?

No, I was thinking about attachment icons in form controls, which would be visible *after* selecting a file in the dialog. But checking the current behavior, I don't see it in the build of Safari that I have. I don't remember when I last saw it work. Perhaps we broke this intentionally, and/or a long time ago?
Comment 7 Alexey Proskuryakov 2020-12-18 12:08:41 PST
Bug 190384 says that attachment icons were incorrect in a specific case, which implies that they were shown at the time in 2018 I think.
Comment 8 Per Arne Vollan 2020-12-18 14:24:04 PST
(In reply to Alexey Proskuryakov from comment #7)
> Bug 190384 says that attachment icons were incorrect in a specific case,
> which implies that they were shown at the time in 2018 I think.

Got it, thanks! I can test if the service is being accessed in this case.
Comment 9 Brent Fulgham 2020-12-18 16:12:50 PST
Comment on attachment 416538 [details]
Patch

r=me
Comment 10 EWS 2021-01-23 07:35:12 PST
Committed r271778: <https://trac.webkit.org/changeset/271778>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 416538 [details].