Bug 220014 – [macOS] Deny mach-lookup to the service 'com.apple.iconservices.store' in the WebContent process

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Per Arne Vollan]

Deny mach-lookup to the service 'com.apple.iconservices.store' in the WebContent process on macOS, since there are no longer any reports of this service being used.

[Per Arne Vollan]

<rdar://problem/68923110>

[Per Arne Vollan]

Created attachment 416515 [details]
Patch

[Alexey Proskuryakov]

Comment on attachment 416515 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=416515&action=review

> Source/WebKit/ChangeLog:10
> +        since there are no longer any reports of this being used.

Out of curiosity, how do we get icons for file input form controls now?

[Per Arne Vollan]

(In reply to Alexey Proskuryakov from comment #3)
> Comment on attachment 416515 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=416515&action=review
> 
> > Source/WebKit/ChangeLog:10
> > +        since there are no longer any reports of this being used.
> 
> Out of curiosity, how do we get icons for file input form controls now?

We are creating extensions for the open file dialog. Is that the case you’re thinking of?

Thanks for reviewing!

[Per Arne Vollan]

Created attachment 416538 [details]
Patch

[Alexey Proskuryakov]

> We are creating extensions for the open file dialog. Is that the case you’re
> thinking of?

No, I was thinking about attachment icons in form controls, which would be visible *after* selecting a file in the dialog. But checking the current behavior, I don't see it in the build of Safari that I have. I don't remember when I last saw it work. Perhaps we broke this intentionally, and/or a long time ago?

[Alexey Proskuryakov]

Bug 190384 says that attachment icons were incorrect in a specific case, which implies that they were shown at the time in 2018 I think.

[Per Arne Vollan]

(In reply to Alexey Proskuryakov from comment #7)
> Bug 190384 says that attachment icons were incorrect in a specific case,
> which implies that they were shown at the time in 2018 I think.

Got it, thanks! I can test if the service is being accessed in this case.

[Brent Fulgham]

Comment on attachment 416538 [details]
Patch

r=me

[EWS]

Committed r271778: <https://trac.webkit.org/changeset/271778>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 416538 [details].