Bug 220008 - Add tagging to JIT probe's return address.
Summary: Add tagging to JIT probe's return address.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-12-17 23:30 PST by Mark Lam
Modified: 2020-12-18 11:27 PST (History)
7 users (show)

See Also:


Attachments
proposed patch. (7.39 KB, patch)
2020-12-17 23:35 PST, Mark Lam
keith_miller: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2020-12-17 23:30:26 PST
rdar://71279530
Comment 1 Mark Lam 2020-12-17 23:35:32 PST
Created attachment 416500 [details]
proposed patch.
Comment 2 Robin Morisset 2020-12-18 08:42:37 PST
Comment on attachment 416500 [details]
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=416500&action=review

LGTM, but I don't understand this code well enough to r+ it.

> Source/JavaScriptCore/assembler/MacroAssemblerARM64.cpp:524
> +    "sub       x27, x27, #" STRINGIZE_VALUE_OF(2 * GPREG_SIZE) "\n" // The retun point PC is at 2 instructions before the end of the probe.

retun -> return
Comment 3 Keith Miller 2020-12-18 10:58:33 PST
Comment on attachment 416500 [details]
proposed patch.

r=me
Comment 4 Mark Lam 2020-12-18 11:27:03 PST
Thanks for the reviews.  Landed in r270981: <http://trac.webkit.org/r270981>.