Bug 220003 - Gate all of the code associated with app highlights
Summary: Gate all of the code associated with app highlights
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Megan Gardner
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-12-17 19:34 PST by Megan Gardner
Modified: 2020-12-18 10:25 PST (History)
9 users (show)

See Also:

Attachments
Patch (23.59 KB, patch)
2020-12-17 19:40 PST, Megan Gardner 		no flags Details | Formatted Diff | Diff
Patch (23.73 KB, patch)
2020-12-17 19:57 PST, Megan Gardner 		no flags Details | Formatted Diff | Diff
Patch for landing (23.72 KB, patch)
2020-12-18 09:32 PST, Megan Gardner 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Megan Gardner 2020-12-17 19:34:11 PST 
Gate all of the code associated with app highlights
Comment 1 Megan Gardner 2020-12-17 19:40:02 PST 
Created attachment 416491 [details]
Patch
Comment 2 Megan Gardner 2020-12-17 19:40:33 PST 
<rdar://problem/72451893>
Comment 3 Tim Horton 2020-12-17 19:43:00 PST 
Comment on attachment 416491 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=416491&action=review

> Source/WTF/Scripts/Preferences/WebPreferencesInternal.yaml:57
>    humanReadableDescription: "Enable persistant highlights for apps"

While here, please “persistent”

> Source/WebCore/rendering/RenderTheme.h:165
> +#if ENABLE(APP_HIGHLIGHTS)

Definitely recommend moving this up a line
Comment 4 Megan Gardner 2020-12-17 19:57:37 PST 
Created attachment 416493 [details]
Patch
Comment 5 Megan Gardner 2020-12-18 09:32:12 PST 
Created attachment 416525 [details]
Patch for landing
Comment 6 EWS 2020-12-18 10:25:58 PST 
Committed r270974: <https://trac.webkit.org/changeset/270974>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 416525 [details].