Bug 219994 - [run-webkit-tests] Replace FailureNotTested with FailureNoOutput
Summary: [run-webkit-tests] Replace FailureNotTested with FailureNoOutput
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-12-17 13:08 PST by Jonathan Bedard
Modified: 2020-12-17 15:18 PST (History)
6 users (show)

See Also:


Attachments
Patch (4.07 KB, patch)
2020-12-17 14:20 PST, Jonathan Bedard
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2020-12-17 13:08:06 PST
The tests we mark as "not tested" more accurately have "no output". We should rename this failure type to reflect the actual behavior so that contributors are not confused.
Comment 1 Radar WebKit Bug Importer 2020-12-17 14:04:17 PST
<rdar://problem/72440201>
Comment 2 Jonathan Bedard 2020-12-17 14:20:51 PST
Created attachment 416468 [details]
Patch
Comment 3 Jonathan Bedard 2020-12-17 14:23:58 PST
This change is coming from some confusion Geoff voiced to me on Slack, seems like we should just rename the error class.
Comment 4 Geoffrey Garen 2020-12-17 14:26:50 PST
Comment on attachment 416468 [details]
Patch

r=me

Thanks!
Comment 5 EWS 2020-12-17 15:18:03 PST
Committed r270953: <https://trac.webkit.org/changeset/270953>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 416468 [details].