Bug 219988 - [webkitscmpy] Remove branches argument from mock Git
Summary: [webkitscmpy] Remove branches argument from mock Git
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-12-17 11:40 PST by Jonathan Bedard
Modified: 2020-12-17 12:31 PST (History)
3 users (show)

See Also:


Attachments
Patch (4.07 KB, patch)
2020-12-17 11:43 PST, Jonathan Bedard
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2020-12-17 11:40:34 PST
The "branches" argument to the mock Git object is not very useful and makes the code more difficult to work with. We should just remove the option.
Comment 1 Radar WebKit Bug Importer 2020-12-17 11:41:00 PST
<rdar://problem/72434657>
Comment 2 Jonathan Bedard 2020-12-17 11:43:20 PST
Created attachment 416445 [details]
Patch
Comment 3 EWS 2020-12-17 12:31:15 PST
Committed r270941: <https://trac.webkit.org/changeset/270941>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 416445 [details].