Bug 219975 – [macOS] Use low-power audio buffer sizes for more output devices

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Jer Noble]

[macOS] Use low-power audio buffer sizes for more output devices

[Jer Noble]

<rdar://problem/72391280>

[Jer Noble]

Created attachment 416388 [details]
Patch

[Jer Noble]

Created attachment 416392 [details]
Patch

[Eric Carlson]

Comment on attachment 416392 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=416392&action=review

> Source/WebCore/platform/audio/AudioHardwareListener.cpp:42
> +    m_supportedBufferSizes = { 32, 4096 };

Can you initialize this in the header?

> Source/WebCore/platform/audio/mac/AudioHardwareListenerMac.cpp:72
> +        return { 0, 0 };

Wouldn't `return { }` do the same?

> Source/WebCore/platform/audio/mac/AudioHardwareListenerMac.cpp:84
> +        return { 0, 0 };

Ditto.

[Jer Noble]

(In reply to Eric Carlson from comment #4)
> Comment on attachment 416392 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=416392&action=review
> 
> > Source/WebCore/platform/audio/AudioHardwareListener.cpp:42
> > +    m_supportedBufferSizes = { 32, 4096 };
> 
> Can you initialize this in the header?

I didn't really want to put a conditional variable initializer in the header.

> > Source/WebCore/platform/audio/mac/AudioHardwareListenerMac.cpp:72
> > +        return { 0, 0 };
> 
> Wouldn't `return { }` do the same?

Probably!

> > Source/WebCore/platform/audio/mac/AudioHardwareListenerMac.cpp:84
> > +        return { 0, 0 };
> 
> Ditto.

[Jer Noble]

Created attachment 416441 [details]
Patch for landing

[EWS]

Committed r270943: <https://trac.webkit.org/changeset/270943>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 416441 [details].