...
Created attachment 416383 [details] Patch
Created attachment 416387 [details] Patch
Created attachment 416426 [details] Patch
Comment on attachment 416426 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=416426&action=review > Source/WebCore/platform/mediastream/CaptureDevice.h:70 > + bool mocked() const { return m_mocked; } > + void setMocked(bool mocked) { m_mocked = mocked; } Nit: I think `mockDevice` or `isMockDevice` would be better than `mocked` > Source/WebCore/platform/mediastream/CaptureDevice.h:133 > + bool m_mocked { false }; Is there any reason to not add this to the encoder and decoder methods? > Source/WebKit/UIProcess/SpeechRecognitionRemoteRealtimeMediaSourceManager.h:76 > + HashSet<WebCore::RealtimeMediaSourceIdentifier> m_sourcesNeedSandboxExtension; Nit: `m_sourcesNeedingSandboxExtension` might be a better name. > Source/WebKit/UIProcess/SpeechRecognitionServer.h:85 > + SpeechRecognitionCheckIfMockSpeechRecognitionEnabled m_checkIfmockSpeechRecognitionEnabled; s/m_checkIfmock/m_checkIfMock/
(In reply to Eric Carlson from comment #4) > Comment on attachment 416426 [details] > Patch Thanks for the review! > > View in context: > https://bugs.webkit.org/attachment.cgi?id=416426&action=review > > > Source/WebCore/platform/mediastream/CaptureDevice.h:70 > > + bool mocked() const { return m_mocked; } > > + void setMocked(bool mocked) { m_mocked = mocked; } > > Nit: I think `mockDevice` or `isMockDevice` would be better than `mocked` Will update. > > > Source/WebCore/platform/mediastream/CaptureDevice.h:133 > > + bool m_mocked { false }; > > Is there any reason to not add this to the encoder and decoder methods? Nope, will add > > > Source/WebKit/UIProcess/SpeechRecognitionRemoteRealtimeMediaSourceManager.h:76 > > + HashSet<WebCore::RealtimeMediaSourceIdentifier> m_sourcesNeedSandboxExtension; > > Nit: `m_sourcesNeedingSandboxExtension` might be a better name. Will update! > > > Source/WebKit/UIProcess/SpeechRecognitionServer.h:85 > > + SpeechRecognitionCheckIfMockSpeechRecognitionEnabled m_checkIfmockSpeechRecognitionEnabled; > > s/m_checkIfmock/m_checkIfMock/
Created attachment 416534 [details] Patch for landing
Committed r270986: <https://trac.webkit.org/changeset/270986> All reviewed patches have been landed. Closing bug and clearing flags on attachment 416534 [details].
<rdar://problem/72477329>