WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED DUPLICATE of
bug 220050
219971
FrameView::sendResizeEventIfNeeded() should not be a post-layout task
https://bugs.webkit.org/show_bug.cgi?id=219971
Summary
FrameView::sendResizeEventIfNeeded() should not be a post-layout task
Simon Fraser (smfr)
Reported
2020-12-16 19:51:07 PST
* frame #0: 0x00000001ce4d2319 WebCore`WebCore::FrameView::sendResizeEventIfNeeded(this=0x00007f9d628f4000) at FrameView.cpp:3398:24 frame #1: 0x00000001ce4d1e91 WebCore`WebCore::FrameView::performPostLayoutTasks(this=0x00007f9d628f4000) at FrameView.cpp:3355:5 frame #2: 0x00000001ce4dc598 WebCore`WebCore::FrameViewLayoutContext::runAsynchronousTasks(this=0x00007f9d628f4138) at FrameViewLayoutContext.cpp:301:12 frame #3: 0x00000001ce4dce7c WebCore`WebCore::FrameViewLayoutContext::runOrScheduleAsynchronousTasks(this=0x00007f9d628f4138) at FrameViewLayoutContext.cpp:287:5 frame #4: 0x00000001ce4bcb50 WebCore`WebCore::FrameViewLayoutContext::layout(this=0x00007f9d628f4138) at FrameViewLayoutContext.cpp:260:9 frame #5: 0x00000001ce4dc4bf WebCore`WebCore::FrameViewLayoutContext::layoutTimerFired(this=0x00007f9d628f4138) at FrameViewLayoutContext.cpp:468:5 The layout zero-delay timer should not trigger "resize" event firing. Resize events should be fired as part of HTML Event Loop.
Attachments
Add attachment
proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1
2020-12-16 21:00:28 PST
Actually the poorly-named FrameView::sendResizeEventIfNeeded() calls setNeedsDOMWindowResizeEvent() so maybe it's OK.
Ryosuke Niwa
Comment 2
2020-12-17 23:23:39 PST
(In reply to Simon Fraser (smfr) from
comment #1
)
> Actually the poorly-named FrameView::sendResizeEventIfNeeded() calls > setNeedsDOMWindowResizeEvent() so maybe it's OK.
Yeah, we should probably rename that function since that resize event event loop integration patch stuck. I didn't do the rename because it would have made the patch really big and hard to revert.
Simon Fraser (smfr)
Comment 3
2020-12-22 08:02:34 PST
*** This bug has been marked as a duplicate of
bug 220050
***
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug